Thanks to Sergio Talens-Oliag <sto@debian.org> for the bug report and patch.

Jacob Anawalt authored 14 years ago and intrigeri committed 14 years ago

Removed an extra '.' in file names introduced by the pg_dump options
patch, resulting in names like db..sql or db..sql.gz instead of just
db.sql or db.sql.gz.

Jacob Anawalt authored 14 years ago and intrigeri committed 14 years ago

The format option of pg_dump enables tar and custom archive file formats in
addition to the default plain-text file containing SQL commands.

When either the tar or custom format are selected the behaviour of database=all is changed to no longer dump a single file via pg_dumpall. Instead pg_dumpall
is called once to export the "global" data (roles & tablespaces) and then
pg_dump is called once for each non-template table in the database.

To support the GZIP and GZIP_OPTS variables in backupninja and to give the
default --rsyncable gzip compression flag a chance at working on a PostgreSQL
backup, the custom output is forced to not use compression. Instead compression
is done via a pipe to gzip. Hopefully this benefits rsync and rdiff-backup
style backups for reduced backup and storage costs that outweigh the
restoration ones.

... so that this option can be disabled on systems that don't support it.
This also allows to use another compression program, such as pbzip2 on SMP
machines (closes Roundup bug #2405).

This should fix Redmine bug #1340.

This option makes pipelines return as status the value of the last (rightmost)
command to exit with a non-zero status, or zero if all commands exit
successfully. See bash(1) for details.

E.g. this prevents the following from exiting with status 0 (!) if pg_dumpall
fails:

        pg_dumpall | gzip

... to support shell meta-characters in database names.
Closes Redmine bug #617.

The modelines added match the emacs lines already present and also set
the filetype to sh (just like the emacs lines).

Previously, there were many indentation styles in use: Real tabs, 2, 3
or 4 spaces, mixing these within the same file, function or even within
a single line.

This commit changes all bash scripts in the handlers, src and lib dirs
to use consistent indentation: three spaces are now used everywhere.
Other files (e.g. Makefiles) are left untouched.

Additionally, this commit removes all trailing whitespace.

and md5sum locations

comitting change to pgsql handler that I forgot to change, allows
the postgresql user to be set in backupninja.conf, instead of hardcoded

http://lists.debian.org/debian-devel-announce/2006/03/msg00003.html

 Reverted indentation level to 3.

 Changed default indentation level to 8, to make it presbyopia-friendly

 Replaced awful "grep /etc/passwd" with getent calls in pgsql and mysql handlers