Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
backupninja
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Liberate
backupninja
Commits
8f7a366d
Commit
8f7a366d
authored
19 years ago
by
micah
Browse files
Options
Downloads
Patches
Plain Diff
Fixed su quoting usage, as outlined here:
http://lists.debian.org/debian-devel-announce/2006/03/msg00003.html
parent
0e353b42
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
ChangeLog
+7
-1
7 additions, 1 deletion
ChangeLog
examples/example.rdiff
+1
-1
1 addition, 1 deletion
examples/example.rdiff
handlers/mysql
+4
-4
4 additions, 4 deletions
handlers/mysql
handlers/pgsql
+4
-4
4 additions, 4 deletions
handlers/pgsql
with
16 additions
and
10 deletions
ChangeLog
+
7
−
1
View file @
8f7a366d
version 0.9.4 -- unreleased
handler changes
mysql, pgsql, svn: fixed inversed vsname emptyness check
mysql:
. Fixed improper use of $vuserhome (Debian: #351083)
. Fixed erroneous removal of tmpfile when it didn't exit
. Fixed inversed vsname emptiness check
. Fixed su quote usage to be more posixy
pgsql:
. Fixed inversed vsname emptiness check
. Fixed su quote usage to be more posixy
svn:
. Fixed inversed vsname emptiness check
rdiff:
. Fixed improper include/exclude symlink dereference
dup:
...
...
This diff is collapsed.
Click to expand it.
examples/example.rdiff
+
1
−
1
View file @
8f7a366d
...
...
@@ -86,7 +86,7 @@ directory = /backups
host = backuphost
# make the files owned by this user. you must be able to
# `su -c ssh backupuser@backhost` without specifying a password.
# `su -c
"
ssh backupuser@backhost
"
` without specifying a password.
# only use if "[dest] type = remote"
user = backupuser
This diff is collapsed.
Click to expand it.
handlers/mysql
+
4
−
4
View file @
8f7a366d
...
...
@@ -179,7 +179,7 @@ then
else
execstr
=
"
$MYSQLHOTCOPY
--quiet --allowold --regexp /.
\*
/./.
\*
/
$hotdir
"
fi
debug
"
su
$user
-c
'
$execstr
'
"
debug
'
su $user -c
"
$execstr"
'
if
[
!
$test
]
then
output
=
`
su
$user
-c
"
$execstr
"
2>&1
`
...
...
@@ -202,7 +202,7 @@ then
else
execstr
=
"
$MYSQLHOTCOPY
--allowold
$db
$hotdir
"
fi
debug
"
su
$user
-c
'
$execstr
'
"
debug
'
su $user -c
"
$execstr"
'
if
[
!
$test
]
then
output
=
`
su
$user
-c
"
$execstr
"
2>&1
`
...
...
@@ -230,7 +230,7 @@ then
then
if
[
$usevserver
=
yes
]
then
debug
"
echo show databases |
$VSERVER
$vsname
exec su
$user
-c
$MYSQL
$defaultsfile
| grep -v Database
"
debug
'
echo show databases | $VSERVER $vsname exec su $user -c
"
$MYSQL $defaultsfile
"
| grep -v Database
'
databases
=
`
echo
'show databases'
|
$VSERVER
$vsname
exec
su
$user
-c
"
$MYSQL
$defaultsfile
"
|
grep
-v
Database
`
if
[
$?
-ne
0
]
then
...
...
@@ -253,7 +253,7 @@ fi
else
execstr
=
"
$MYSQLDUMP
$defaultsfile
--lock-tables --complete-insert --add-drop-table --quick --quote-names
$ignore
$db
>
$dumpdir
/
${
db
}
.sql"
fi
debug
"
su
$user
-c
'
$execstr
'
"
debug
'
su $user -c
"
$execstr"
'
if
[
!
$test
]
then
output
=
`
su
$user
-c
"
$execstr
"
2>&1
`
...
...
This diff is collapsed.
Click to expand it.
handlers/pgsql
+
4
−
4
View file @
8f7a366d
...
...
@@ -72,9 +72,9 @@ chmod 700 $vroot$backupdir
# if $databases = all, use pg_dumpall
if
[
"
$databases
"
==
"all"
]
;
then
if
[
$usevserver
=
yes
]
;
then
execstr
=
"
$VSERVER
$vsname
exec su - postgres -c
$PGSQLDUMPALL
>
$backupdir
/
${
vsname
}
.sql"
execstr
=
'
$VSERVER $vsname exec su - postgres -c
"
$PGSQLDUMPALL > $backupdir/${vsname}.sql"
'
else
execstr
=
"
su - postgres -c
$PGSQLDUMPALL
>
$backupdir
/
${
localhost
}
-all.sql"
execstr
=
'
su - postgres -c
"
$PGSQLDUMPALL > $backupdir/${localhost}-all.sql"
'
fi
debug
"
$execstr
"
if
[
!
$test
]
;
then
...
...
@@ -94,9 +94,9 @@ else
for
db
in
$databases
;
do
if
[
$usevserver
=
yes
]
then
execstr
=
"
$VSERVER
$vsname
exec su - postgres -c
$PGSQLDUMP
$db
>
$backupdir
/
${
db
}
.sql"
execstr
=
'
$VSERVER $vsname exec su - postgres -c
"
$PGSQLDUMP $db > $backupdir/${db}.sql"
'
else
execstr
=
"
su - postgres -c
$PGSQLDUMP
$db
>
$backupdir
/
${
db
}
.sql"
execstr
=
'
su - postgres -c
"
$PGSQLDUMP $db > $backupdir/${db}.sql"
'
fi
debug
"
$execstr
"
if
[
!
$test
]
;
then
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment