Skip to content
Snippets Groups Projects

A GUI for mat2 written in PyQt5

Closed fboi312 requested to merge (removed):GUI into master
All threads resolved!

Addressing issue #3 (closed) .

To see the UI follow the steps below

  1. Download PyQt5
  2. cd ui
  3. python3 main.py

No files other than the ones in the new (proposed) ui directory have been touched.

Because of the lack of a proper API, this user interface does nothing other than selecting files and showing dialogs.

Naming of variables and functions in Qt follows the Letter case-separated words whereas pep8 suggests Delimiter-separated words where the delimiter is _. For the time being I have followed the Qt style. Other than this I have conformed to pep8.

Merge request reports

Closed by avatar (May 3, 2025 6:43pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • By proper API I meant the absence of a function like show_meta which just returns the metadata as a string. I guess the code has been written with only the CLI in mind. The processing can be separated from the user interface following the MVC design pattern.

    This processing code can then used by both cli and GUI seperately.

    PS: I guess I should have named the directory gui

  • jvoisin
  • Couple of comments:

    • The show metadata button is present even when no files are selected
    • The show metadata button doesn't do anything
    • I got a qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 1143, resource id: 8305287, major code: 40 (TranslateCoords), minor code: 0 when selecting the ui/images/mat2.png file
    • There is no way to select multiple files
    • The user can select any file they want, it would be nice to restrict the selection to the supported file formats
    • When clicking on "remove metadata", the user is presented with confusing choices: there should be a way to show some context/information about them. Moreover, I don't think it's worth exposing the "No sandbox" mode, since this option is only for advanced users. Also, the "in place" mode is dangerous, and shouldn't be used by users who needs a GUI to use mat2 in my opinion.

    But I like the idea of having a simple gui to use mat2, thanks for doing this

  • fboi312 added 3 commits

    added 3 commits

    • 0f1b1d41 - Disable buttons when not needed
    • f8d87501 - Restrict selection to supported file formats
    • 3dc4d27c - Change single file selection to multiple file selection

    Compare with previous version

  • fboi312 resolved all threads

    resolved all threads

  • fboi312 added 1 commit

    added 1 commit

    Compare with previous version

  • fboi312 added 7 commits

    added 7 commits

    • 4acf3af0 - 1 commit from branch jvoisin:master
    • b9ab4831 - Add GUI
    • 3870aab4 - Add some dialogs
    • 7e06f4dd - Disable buttons when not needed
    • ef68c5f8 - Restrict selection to supported file formats
    • 5caca424 - Change single file selection to multiple file selection
    • fad8f304 - Improve GUI

    Compare with previous version

    • Resolved by fboi312

      I need clean_meta, show_meta, __check_file available in mat2 file to show metadata and delete metadata. So should I implement them in ui/mainwindow.py (where I need them) or should I import them from mat2? Or these functions can be shifted to libmat2, from there both cli and GUI can use them.

      Edited by fboi312
  • closed

  • fboi312 resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading