Skip to content
Snippets Groups Projects
Select Git revision
  • main
  • 463-migrate-signald-data-store-to-signalc
  • 486-prod-deploy-tooling
  • 493-modify-identity-store-impl
  • 479-support-delete-account-command
  • spike-resolve-unidentified-senders-correctly
  • 478-fix-signalc-decryption-errors
  • hf-snowflake-backup-dont-delete
  • 459-reduce-signalc-lag-to-acceptable-levels
  • 482-port-signalboost-to-kotlin
  • 431-hello-goodbye-partial-lang-support
  • 431-hello-goodbye-burmese
  • 391-design-for-encrypting-user-metadata-at-rest
  • 298-sc-relay-messages-over-unix-socket
  • 201-BACKUP
  • 393-signalc-register-number-and-send-message
  • test-ci
  • hf-harden-intervals-and-info-response
  • 363-publish-privacy-policy
  • WIP-docker-module
20 results

signalc

  • Clone with SSH
  • Clone with HTTPS
  • aguestuser's avatar
    [hf] fixup mr !599 - cleanup SignalReceiver/ContactStore
    aguestuser authored
    SignalReceiver:
    
    - make helpers in different branches of `#dispatch` return
      `Unit` instead of `Job?` (we never used the job and it was odd to
      return null from 3/4 of the branches!)
    - call `ContactStore#create` with uuid and phone number from
      `#handlePreKeyBundle` (instead of calling overloaded `#create` that
      takes an envelope as arg) to (1) be simpler, (2) make it more
      explicit why we are storing both pieces of data at this
      point in the session lifecycle
    - revise the comment for `#handlePreKeyBundle` (it is a "hot spot" and
      likely to be the source of lots of confusion to future us when less
      debugging state is loaded in our heads!)
    
    ContactStore
    
    - revise `ContactStore#hasContact` to be slightly more
      straightforward (if less terse)
    - remove overloaded `#create` (which is no longer called)
    dfc82895
    History
    Name Last commit Last update
    ..