-
- Downloads
[hf] fixup mr !599 - cleanup SignalReceiver/ContactStore
SignalReceiver: - make helpers in different branches of `#dispatch` return `Unit` instead of `Job?` (we never used the job and it was odd to return null from 3/4 of the branches!) - call `ContactStore#create` with uuid and phone number from `#handlePreKeyBundle` (instead of calling overloaded `#create` that takes an envelope as arg) to (1) be simpler, (2) make it more explicit why we are storing both pieces of data at this point in the session lifecycle - revise the comment for `#handlePreKeyBundle` (it is a "hot spot" and likely to be the source of lots of confusion to future us when less debugging state is loaded in our heads!) ContactStore - revise `ContactStore#hasContact` to be slightly more straightforward (if less terse) - remove overloaded `#create` (which is no longer called)
parent
2b4df8e5
No related branches found
No related tags found
Showing
- signalc/src/main/kotlin/info/signalboost/signalc/Mocks.kt 0 additions, 1 deletionsignalc/src/main/kotlin/info/signalboost/signalc/Mocks.kt
- signalc/src/main/kotlin/info/signalboost/signalc/logic/SignalReceiver.kt 28 additions, 32 deletions...n/kotlin/info/signalboost/signalc/logic/SignalReceiver.kt
- signalc/src/main/kotlin/info/signalboost/signalc/store/ContactStore.kt 9 additions, 4 deletions...ain/kotlin/info/signalboost/signalc/store/ContactStore.kt
- signalc/src/test/kotlin/info/signalboost/signalc/logic/SignalReceiverTest.kt 14 additions, 8 deletions...tlin/info/signalboost/signalc/logic/SignalReceiverTest.kt
- signalc/src/test/kotlin/info/signalboost/signalc/store/ContactStoreTest.kt 0 additions, 12 deletions...kotlin/info/signalboost/signalc/store/ContactStoreTest.kt
Loading
Please register or sign in to comment