Skip to content
Snippets Groups Projects
Commit dfc82895 authored by aguestuser's avatar aguestuser
Browse files

[hf] fixup mr !599 - cleanup SignalReceiver/ContactStore

SignalReceiver:

- make helpers in different branches of `#dispatch` return
  `Unit` instead of `Job?` (we never used the job and it was odd to
  return null from 3/4 of the branches!)
- call `ContactStore#create` with uuid and phone number from
  `#handlePreKeyBundle` (instead of calling overloaded `#create` that
  takes an envelope as arg) to (1) be simpler, (2) make it more
  explicit why we are storing both pieces of data at this
  point in the session lifecycle
- revise the comment for `#handlePreKeyBundle` (it is a "hot spot" and
  likely to be the source of lots of confusion to future us when less
  debugging state is loaded in our heads!)

ContactStore

- revise `ContactStore#hasContact` to be slightly more
  straightforward (if less terse)
- remove overloaded `#create` (which is no longer called)
parent 2b4df8e5
No related branches found
No related tags found
1 merge request!601[hf] fixup mr !599 - cleanup SignalReceiver/ContactStore
Pipeline #61158 passed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment