[bugfix] fix bugs introduced by #78
#78 (closed) introduced several bugs. this fixes them
BUG 1:
-
channelRepososotory#resolveSenderType
and#resolveSenderLanguage
both produced null subscriberPhoneNumber/publisherPhoneNumber by improper usage of `lodash#times`` - fix by using
times
properly (calling a lambda) and introduce unit tests for these functions
BUG 2:
-
registrar.channel.create
callsdispatcher.messenger.welcomeNewPublisher
, which expects a value for language (which we do not have yet) to pass tomessagesIn
- fix by making
messagesIn
default to default language messages if no language provided
BUG 3:
- find-and-replace elimination of
messageTypes
prefix indispatcher.messenger
unintentionally eliminatedsignal.messageTypes
prefix, causing all signald messages to have no type, causing signald to throw NPEs - fix: reintroduce
signal.messageTypes
namespace (and give it asdMessageTypes
aliases to make it harder to make this mistake)