[#494] Resolve "sc-tech-task: rename `name` to `contactId` in all relevant protocol store tables"
Closes #494 (closed)
context
-
name
is what the field is called onSignalProtocolAddress
.- (it is the equivalent to the
identifier
field on aSignalServiceEnvelope
which is ambiguous between a UUID or an e164 phone number, preferring the former, but falling back to the latter if none is available)
- (it is the equivalent to the
- in general,
name
is a very confusing variable name! - in the context of a protocol store, where we have an
accountId
, it would make the most sense to rename this fieldcontactId
(rather thanname
) - so: let's do it before we move a whole bunch of data around into a new schema!
changes
- rename
name
column inidentities
andsessions
tables (along with all indexes and primary keys that used to use thename
column) - rename the
AccountsWithAddress
exposed interface to beDeviceRecord
(to distinguish them from a soon-to-be-implemented interface calledContactRecord
which does not include device ids)
Edited by aguestuser