[#494] Resolve "sc-tech-task: rename `name` to `contactId` in all relevant protocol store tables"
Closes #494 (closed)
context
-
nameis what the field is called onSignalProtocolAddress.- (it is the equivalent to the
identifierfield on aSignalServiceEnvelopewhich is ambiguous between a UUID or an e164 phone number, preferring the former, but falling back to the latter if none is available)
- (it is the equivalent to the
- in general,
nameis a very confusing variable name! - in the context of a protocol store, where we have an
accountId, it would make the most sense to rename this fieldcontactId(rather thanname) - so: let's do it before we move a whole bunch of data around into a new schema!
changes
- rename
namecolumn inidentitiesandsessionstables (along with all indexes and primary keys that used to use thenamecolumn) - rename the
AccountsWithAddressexposed interface to beDeviceRecord(to distinguish them from a soon-to-be-implemented interface calledContactRecordwhich does not include device ids)
Edited by aguestuser