Skip to content

[327] send broadcast messages in sequence (not parallel)

aguestuser requested to merge 327-send-broadcast-messages-in-sequence into master

Closes #327 (closed)

context

  • a series of experiments with healtchecks (see: !354 (merged), !355 (merged), !356 (merged), !357 (merged)) have yielded evidence that sending batches of messages sequentially rather than in parallel can dramatically reduce the overall transmission time for the same number of messages (from ~30sec to ~500ms)
  • we don't yet understand the cause, but have observed the outcome consistently enough that we want to introduce the same pattern with our broadcast messages to see if it provides a decent stopgap solution for message lag while we are working on longer term improvements to concurrency in signald

changes

  • modify signal.broadcastMessages to send messages in sequence rather than in parallel (pending upstream changes to allow signald to efficiently handle messages sent in parallel)

Merge request reports