Resolve "incorporate upstream signald changes to `trust` command"
Closes #316 (closed)
Context
Finn is changing lots of stuff upstream and we want to pull it in to:
- be up to date with upstream when we start adding isntrumentation code
- pull in good changes he's making to identity failure handling (including one that allows us to handle incoming identity failures and some connected code that changes how UUID intitialization happens in the keystore)
Changes
change dockerfile to use different signald build:
- update to use this commit in the team-friendo fork:
- repo: https://0xacab.org/team-friendo/signald-fork.git
- branch: master
- commit: "35ea9556f54abb124b2048bbcf6f7237d0a99796"
- which tracks this upstream commit in finn's branch:
- repo: https://gitlab.com/thefinn93/signald
- branch: automated-upgrade/com.github.turasa-signal-service-java
- commit: ae7e8e4d963894cf6758466d88cc70c12d8952d7
handle inbound identity failures in dispatcher.index
- extract
updateFingerprint
tosafetyNumbers
for shared use indispatchers.index
(for inbound failures) andsignal.callbacks
(for outbound failures) - handle inbound identity failure in
dispatcher.index
by constructing anUpdatableFingerprint
and passing it tosafetyNumbers.updateFingerprint
(which will either deauthorize an admin or trust and notify a subscriber to resend) - add localized responses to inbound safety number changes
eliminate unnecessary wait
in trustAndResend
aguestuser authored 1 day ago
- had inserted a wait command to avoid rate-limiting
- but the rate limit error i was was seeing a was a per-account prekey fetching rate limit that only occured b/c i was reinstalling signal so many times in a row for debuggin
- since this is not likely to happen in prod, and not fixable by a short delay, we omit it
Edited by aguestuser