Skip to content

Resolve "incorporate upstream signald changes to `trust` command"

Closes #316 (closed)

Context

Finn is changing lots of stuff upstream and we want to pull it in to:

  1. be up to date with upstream when we start adding isntrumentation code
  2. pull in good changes he's making to identity failure handling (including one that allows us to handle incoming identity failures and some connected code that changes how UUID intitialization happens in the keystore)

Changes

change dockerfile to use different signald build:

handle inbound identity failures in dispatcher.index

  • extract updateFingerprint to safetyNumbers for shared use in dispatchers.index (for inbound failures) and signal.callbacks (for outbound failures)
  • handle inbound identity failure in dispatcher.index by constructing an UpdatableFingerprint and passing it to safetyNumbers.updateFingerprint (which will either deauthorize an admin or trust and notify a subscriber to resend)
  • add localized responses to inbound safety number changes

eliminate unnecessary wait in trustAndResend aguestuser authored 1 day ago

  • had inserted a wait command to avoid rate-limiting
  • but the rate limit error i was was seeing a was a per-account prekey fetching rate limit that only occured b/c i was reinstalling signal so many times in a row for debuggin
  • since this is not likely to happen in prod, and not fixable by a short delay, we omit it
Edited by aguestuser

Merge request reports