Skip to content

82 adds french command and notification interface

Margot requested to merge 82-so-you-wanna-speak-french into master

Closes #82 (closed) sort of -- honestly that card is bigger in scope but it's what inspired this and the contrib doc says to reference a ticket :) I also included some small notification formatting changes across the languages.

@aguestuser I'm asking for code review, feedback and a chance to perhaps pair on tests. I've never done development in this stack before and i'm mostly just doing what I see so can benefit from feedback and you should not assume anything i did that appears wrong was thoughtfully intentional.

I extended the existing tests i found for langs, I tested them in a fail state and then fixed them so they are tested tests :) Id be curious to pair a little on Mocha sometime.

FYI When i run tests i get these errors. These fails happen in master as well, i didn't make them that i know of.

 2 failing

  1) routes
       "before all" hook:
     TypeError: Cannot read property 'server' of undefined
      at _callee$ (services/registrar/routes.spec.js:41:67)
      at tryCatch (/signalboost/node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (/signalboost/node_modules/regenerator-runtime/runtime.js:296:22)
      at Generator.prototype.(anonymous function) [as next] (/signalboost/node_modules/regenerator-runtime/runtime.js:114:21)
      at step (/signalboost/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
      at /signalboost/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13

  2) routes
       "after all" hook:
     TypeError: Cannot read property 'close' of undefined
      at Context.<anonymous> (services/registrar/routes.spec.js:42:22)

Merge request reports