GitLab

[#113] Resolve "admins can BAN senders of abusive hotline messages"

Closes #113

See merge request !472

* in `#banMember`: destroy any existing membership that the banned
  member might have on the channel from which they are being banned (and wrap
  call in a transaction)
* add `#findBanned` to filter an arbitrary list of member numbers for
  banned numbers (for use when issuing invites or adding)

side-effect: use notification messages (not command responses) to
notify non-issuing admins

bug 1:

* symptom: `execute#banMember` throwing and returning generic db error
* cause: `banRepository.banMember` not being passed mandatory first
  `channelPhoneNumber` arg
* fix: insert the required argument (and add some logging to help
  detect bugs like this)

bug 2:

* symptom: extra ban notification sent (sending admin gets CR and notification)
* cause: this branch didn't incorporate schema change in which
  `sender` is now a membership, and thus `sender.phoneNumber` returns
  `undefined` in `execute#banNofitificationsOf`'s call to
  `channelRespository#getAllAdminsExcept`
*fix: call `sender.memberPhoneNumber` instead of `sender.phoneNumber`

[hotfix] include error message in alert for failed channel destruction

See merge request !535

[#397] Automate channel creation

Closes #379

See merge request !528

[hf] correct private message shortcut hint

See merge request !534

* we accidentally list `!` as the shortuct for `PRIVATE` in the
  english-language `HELP` response
* this is potentially catastrophic, since it is actually the shortcut
  for `BROADCAST` (the OPPOSITE of private!!!!)
* we fix it here

[397] change signature of channelRegistrar#create from named arguments to (Array<string>, string | null)