specs: unit: keyword_handlers/key_management: expected, hardcoded key creation dates makes Schleuder build unreproducible
Source: https://tests.reproducible-builds.org/debian/logs/unstable/amd64/schleuder_4.0.3-1.build2.log.gz
Failures:
1) Schleuder::KeywordHandlers::KeyManagement.delete_key deletes multiple keys that each distinctly match one argument
Failure/Error: expect(output).to match(/This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n\n\nThis key was deleted:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/)
expected "This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\...was deleted:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-14 [expired: 2017-01-21]\n" to match /This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n\n\nThis key was deleted:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/
Diff:
@@ -1,6 +1,11 @@
-/This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n\n\nThis key was deleted:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/
+This key was deleted:
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
+
+
+This key was deleted:
+0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-14 [expired: 2017-01-21]
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:173:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
2) Schleuder::KeywordHandlers::KeyManagement.delete_key deletes a key that distinctly matches the argument
Failure/Error: expect(output).to eql("This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n")
expected: "This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n"
got: "This key was deleted:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\n"
(compared using eql?)
Diff:
@@ -1,3 +1,3 @@
This key was deleted:
-0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:158:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
3) Schleuder::KeywordHandlers::KeyManagement.add_key imports a key from attached acsii-armored material
Failure/Error: expect(output).to eql("This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n")
expected: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n"
got: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\n"
(compared using eql?)
Diff:
@@ -1,3 +1,3 @@
This key was newly added:
-0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:52:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
4) Schleuder::KeywordHandlers::KeyManagement.add_key updates a key
Failure/Error: expect(output).to match(/This key was updated:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/)
expected "This key was updated:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-14 [expired: 2017-01-21]\n" to match /This key was updated:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/
Diff:
@@ -1,2 +1,3 @@
-/This key was updated:\n0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-13 \[expired: 2017-01-\d{2}\]\n/
+This key was updated:
+0x98769E8A1091F36BD88403ECF71A3F8412D83889 bla@foo 2010-08-14 [expired: 2017-01-21]
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:129:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
5) Schleuder::KeywordHandlers::KeyManagement.add_key imports a key from attached quoted-printable binary material
Failure/Error: expect(output).to eql("This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n")
expected: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n"
got: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\n"
(compared using eql?)
Diff:
@@ -1,3 +1,3 @@
This key was newly added:
-0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:69:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
6) Schleuder::KeywordHandlers::KeyManagement.add_key ignores body if an ascii-armored attachment is present
Failure/Error: expect(output).to eql("This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n")
expected: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n"
got: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\n"
(compared using eql?)
Diff:
@@ -1,3 +1,3 @@
This key was newly added:
-0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:100:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
7) Schleuder::KeywordHandlers::KeyManagement.add_key imports a key from inline ascii-armored material
Failure/Error: expect(output).to eql("This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n")
expected: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12\n"
got: "This key was newly added:\n0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13\n"
(compared using eql?)
Diff:
@@ -1,3 +1,3 @@
This key was newly added:
-0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-12
+0xC4D60F8833789C7CAA44496FD3FFA6613AB10ECE schleuder2@example.org 2016-12-13
# ./spec/schleuder/unit/keyword_handlers/key_management_spec.rb:24:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:61:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:60:in `block (2 levels) in <top (required)>'
This is similar to #513 (closed), but this time it's not about expiration dates, but about creation dates. Unfortunately, this wasn't reported in the earlier test during Debians reproducible builds, which is why I've missed this.
For the Debian context, I've uploaded 4.0.3-2
shipping a patch which addresses these issues, to check and test if this patch makes Schleuder finally build reproducible again.
Given this, the new CI job to check for such errors via !400 (merged) is too limited, I've submitted !401 (closed) as a draft for now to widen the scope of this job, to have it check any kind of dates.
Ref #268 (closed)