we should try to use qmlfmt, indeed

- remove unused debug
- uncomment notification function, leftover from debug
- comment about go-land mutexes

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

Let's make it easier to tell us how buggy our software is, or how happy they
are to use it :)

- Closes: #422

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

this is a regression that was introduced with previous changes to the
menus in windows. activation segfaults in linux and osx, so capture the event
only for windows. did not investigate further about the causes, but it seems
like a good workaround for the time being.

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

This fixes the segfault.

mRootItem has to be deallocated to avoid memory leaks, but doing it
concurrently with the dump of the json was a terrible idea.

- Closes: #360

- Resolves: #413

They are hidden in transifex.

- Resolves: #414

decodestring is an alias that was deprecated in 3.1

- Resolves: #412

sorry about that :(

We really need this for windows.

However, I'm afraid for regular users in linux/mac the notification
might be too obstrusive. As we commented in the mr, one way around this
might be to only display that tip the first few times - and then persist
a flag about it having been shown.

t h authored 4 years ago and Kali Kaneko committed 4 years ago

- Related: #367, #370

t h authored 4 years ago and Kali Kaneko committed 4 years ago

- Closes: #394

Let's delete as well the locales folder that is not used anymore.

- Resolves: #314

kali authored 4 years ago and Kali Kaneko committed 4 years ago

I kind of liked the "classic" style more (looks cleaner), but it looks
like we only can customize the logo etc with the "modern" look and feel
in windows.

I think the way to go would be to add a QStyleSheet to the installer
(and adding logo etc there), but I think that is going to take some
reading. this is not too bad for now, at least we can put logos to
differentiate riseup/calyx etc.

kali authored 4 years ago and Kali Kaneko committed 4 years ago

squashed in this commit: reintroduce the dummy autostart_win implementation that was
removed by mistake. I did not manage to get autostart working in
windows, this is pending to be re-worked. see leap/bitmask-vpn#389

kali authored 4 years ago and Kali Kaneko committed 4 years ago

Also, install the tap driver silently.

- Resolves: #366

kali authored 4 years ago and Kali Kaneko committed 4 years ago

- Resolves: #383

this was left out of the packaging refactor by mistake.

- Resolves: #368

- Resolves: #374

this is elijah's icon, from leap_assets/branding/riseup/linux/launcher.png