kali authored 4 years ago and Kali Kaneko committed 4 years ago

stop if:

- bitmask is running (we don't want to mess with the helper if the app
  is running)
- we cannot stop the service for some reason.

powershell gives more flexibility to stop services, but Remove-Service
is not present in PS < 6, so we try to remove the service from the
post-install too (the golang helper will complain about an eventlog
registry key).

this could probably be improved in the helper, but we'll be moving to
the official openvpnserv2 service for 0.21.4. we might want to revisit
the current helper for the firewall/killswitch.

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

- install into global /Applications
- document how to troubleshoot helper
- uninstall app is visible on top-level folder
- improve detection of running processes for old and new binaries

- Closes: #441
- Closes: #445
- Closes: #435

it had been changed in the hook itself, but this script kept using the
deprecated form.

- Resolves: #431

- Closes: #436

we should try to use qmlfmt, indeed

- remove unused debug
- uncomment notification function, leftover from debug
- comment about go-land mutexes

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

Let's make it easier to tell us how buggy our software is, or how happy they
are to use it :)

- Closes: #422

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

this is a regression that was introduced with previous changes to the
menus in windows. activation segfaults in linux and osx, so capture the event
only for windows. did not investigate further about the causes, but it seems
like a good workaround for the time being.

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

This fixes the segfault.

mRootItem has to be deallocated to avoid memory leaks, but doing it
concurrently with the dump of the json was a terrible idea.

- Closes: #360

- Resolves: #413

They are hidden in transifex.

- Resolves: #414

decodestring is an alias that was deprecated in 3.1

- Resolves: #412

sorry about that :(

We really need this for windows.

However, I'm afraid for regular users in linux/mac the notification
might be too obstrusive. As we commented in the mr, one way around this
might be to only display that tip the first few times - and then persist
a flag about it having been shown.

t h authored 4 years ago and Kali Kaneko committed 4 years ago

- Related: #367, #370

t h authored 4 years ago and Kali Kaneko committed 4 years ago

- Closes: #394