this fixes a bug where the UI was not updated when the
window is not visible, turning vpn on/off via the tray
didn't update the state correctly i.e the tray  icon's
state would be stuck in the connecting state with  the
yellow icon

using NumberAnimation for the state transition instead
of OpacityAnimator fixes the issue as it seems opacity
animator only works when the window is visible

jkito authored 3 months ago and jkito committed 3 months ago

this adds a new error type when app is not able to
get a lock of the pid file as another instance  is
already running, it then shows a msg and quits

Nowa Ammerlaan authored 5 months ago and jkito committed 5 months ago

which is an external command, command -v is the equivalent shell built-in.

Replacing the calls to which with command -v removes a build time dependency.

Bug: https://bugs.gentoo.org/940563


Signed-off-by: Nowa Ammerlaan <nowa-ammerlaan@riseup.net>

jkito authored 6 months ago and jkito committed 6 months ago

earlier the qmake build always produced the binary named
as bitmask and later it was renamed to whatever PROVIDER
was set to, in the previous commit we fixed the  setting
of TARGET env so that qmake produces the binary with the
correct name

jkito authored 6 months ago and jkito committed 6 months ago

running 'getparam binname' should return the name we want to set
for the qmake TARGET based on the PROVIDER from the  vendor.conf
file, due to running it inside a subshell in make it always gets
the value for the default provider, setting PROVIDER env returns
the correct value

it also updates the qmake project file to use the TARGET env var
and the build script to pass TARGET to qmake command as arg

jkito authored 6 months ago and jkito committed 6 months ago

qmake is not inheriting the env variables from the parent
process to work around this, it is directly passed as arg
to the qmake invocation

jkito authored 6 months ago and jkito committed 6 months ago

as the RELEASE env variable is used to switch between
release or debug builds

It gets generated with `make vendor`. After removing it from git repo,
the gui/providers/ directory does not exist anymore. The
gen-providers-json script fails. Therefore the script was fixed and now
creates gui/providers/ directory.

the backend.quit emits the 'quitDone' signal which also
triggers the 'aboutToQuit' signal for the  QApplication
since its handler calls 'QApplication::quit()'

the handler for 'aboutToQuit' signal already calls Quit
so removing it from backend.quit avoids another call to
Quit

This reverts commit b9fc3584.

the aboutToQuit signal is emitted just before the app closes and
gives chance to run some teardown routines, when closing the app
via a keyboard shortcut (cmd+q on macOS) we get this signal  and
the handler stops the firewall and performs other needed cleanup

removing this causes a bug where quiting the app would keep  the
firewall running which results into no internet access

riseup currently is not having any deployed obfs4 or kcp bridges
but the eip-service.json contains transports[].type as obfs4 for
many of the gateways, therfore the bridge options are explicitly
disabled if the provider name is 'riseup'

this prevents starting openvpn connection automatically after
app start, since currently there's no preference setting  for
it to allow the user to control the behavior

this also sets DisableAutostart to true since it is currently
not working on any of the platforms

this uses the contentItem property of RoundButton to
use an Image item and set the power button as on/off
changing from Icon to Image allows to use the mipmap
property, which should improve the image quality

kwadronaut authored 7 months ago and jkito committed 7 months ago

android, qt, tranxifex all have different ideas on how languages
and locales should pose themselves. It is not relevant for  most
languages where we only have one locale, like Turkish. But if we
have different ones or different scripts, we need to tell  while
downloading updates where to look for them.

this updates the internationalization doc with explanation about
transifex language mapping and removes duplicate language files

solves #888

kwadronaut authored 7 months ago and jkito committed 7 months ago

we currently have language entries which appears to be repeated
but infact they are different languages, e.g es_AR, es_CU  both
show up as 'Spanish' in the language picker, to make it  easier
to distinguish between them the region is added to the lanugage
picker list, so es_CU now appears as 'Spanish (Cuba)'

this added metadata is used by accessibility tools for
aiding the user to interact with the application

the android app is called as Bitmask, this renames the desktop
app to use the same name and keep the naming consistent across
platforms

kwadronaut authored 8 months ago and jkito committed 8 months ago

this updates the qt linguist ts files to target the strings
correctly after the recent UI changes

this adds a check box to the transport section of
preferences to enable KCP and makes the necessary
updates to SetTransport and GetTransport to allow
KCP to be used as a transport name

jkito authored 8 months ago and jkito committed 8 months ago

This reverts commit 09416b1d.

required pkg-config .pc files are not provided by the qt project
on linux the distribution packages contains them but on  windows
and macOS these are not available causing build to fail

ref: https://bugreports.qt.io/browse/QTBUG-86080

`Quit()` in `main.cpp` calls `Quit()` in `gui/backend.go`
which calls `backend.Quit()` (`defined in pkg/backend/api.go`)

ways to test:
- Preferences -> Quit
- Systray -> Quit
- via signal: killall riseup-vpn

When we exit by Systray/Preferences, `QApplication::quit()` gets called
by `&Backend::quitDone` handler.

jkito authored 8 months ago and Pea Nut committed 8 months ago

the C import line is recommended to be on a separate line
this allows to use the comments in the lines preceeding it
to setup various cpp compiler flags

this also uses cgo comments to pass additional import dirs
for the cpp compiler, these are needed for gopls to work

jkito authored 8 months ago and Pea Nut committed 8 months ago

instead of converting QString to GoString struct which is
error prone, this changes SetTransport and UseLocation in
backend.go to receive a char* as arg, which is  converted
to Go string using the C.GoString helper

this fixes a bug on macOS where changing preference options
did not have any effect as the conversion of string was not
working and empty values were passed to Go functions

kwadronaut authored 9 months ago and jkito committed 9 months ago

adds the terms of service url

this removes the go generate way of generating the
pkg/config/version.go file and uses build time  ld
flags to set the version when building from git or
uses .gitattributes to set it during git archive

this was used to create the connect/disconnect button
which now uses an icon instead of this component

this implements the buttons from the new design mockup

earlier the bottom footer toolbar would
disapper when the Drawer was open, with
the new design that is not required

this also removes the 'drawerOn' property
since it is now ununsed

this removes the custom component NavigationDrawer earlier
as during testing with Qt6.4 the default Qml Drawer  works
as expected

since we have stopped creating snap for now this should be
safe to do

this implements the new floating design for the location
selection toolbar, it is now removed from the MainView's
Page footer and added as a object of StatusBox component

Since the StatusBox is in the MainView component's  Page
Content area the background image doesn't extend to  the
Footer area of the Page if a footer is present, hence it
is removed

in the new design the riseup crow image used to
show the disconnected state takes more space

this is part of the new design which replaces the earlier
crow image to show the 'VPN is connected' state

this changes the StatusBox component of the app to use the
background images from the new design to inform about conn
states