kwadronaut authored 9 months ago and jkito committed 8 months ago

this updates the qt linguist ts files to target the strings
correctly after the recent UI changes

this adds a new boolean "KCP" key to the systray.json
config file

kcp is linked to obfs4, so setting kcp to 'true' sets
obfs4 to also true

since io/ioutil package is deprecated now, this uses
equivalent functions from the os package

this adds a check box to the transport section of
preferences to enable KCP and makes the necessary
updates to SetTransport and GetTransport to allow
KCP to be used as a transport name

the startOpenVPN method fetches gateways for the requested transport
starts the local proxy, sets up firewall and then makes the call  to
start openvpn

this introduces helper methods to perform the preparatory tasks before
openvpn can be started, this makes it easier to navigate the function

jkito authored 8 months ago and jkito committed 8 months ago

This reverts commit 09416b1d.

required pkg-config .pc files are not provided by the qt project
on linux the distribution packages contains them but on  windows
and macOS these are not available causing build to fail

ref: https://bugreports.qt.io/browse/QTBUG-86080

`Quit()` in `main.cpp` calls `Quit()` in `gui/backend.go`
which calls `backend.Quit()` (`defined in pkg/backend/api.go`)

ways to test:
- Preferences -> Quit
- Systray -> Quit
- via signal: killall riseup-vpn

When we exit by Systray/Preferences, `QApplication::quit()` gets called
by `&Backend::quitDone` handler.

cli (cmd/bitmask-helper/main.go and) and helpers (pkg/pickle/helpers.go)
were also fixed.

It only calls vpn.Init()

This was introduced in 970c3f4f where the code supported different api
versions, but there was not yet an implementation for v5.
The apiVersion can be set via env. In the future apiVersion will be
fetched from the API using the /providers.json URL"

It only calls config.ConfigureLogger which now get's called directly.

jkito authored 8 months ago and jkito committed 8 months ago

the $APPNAME is a template variable and replace by the gen-qt-installer
script at build time, which allows to have the correct name of the app
on the error message during uninstall

jkito authored 9 months ago and jkito committed 8 months ago

this adds a custom installer page with a checkbox to allow users to
choose to install the app for all users, when its enabled installer
will create a group called 'OpenVPN Administrator'

local users except the admin, guest and default account are added to
the group, and upon uninstall the group is removed

this allows non-admin users that are added to the group to use the app
and successfully start a vpn connection

jkito authored 8 months ago and Pea Nut committed 8 months ago

this is needed to be passed to be able to build
the GUI since our c-archive libgoshim.a imports
the 'net' package

ref: https://github.com/golang/go/issues/58159
https://tip.golang.org/doc/go1.20#cgo

jkito authored 9 months ago and Pea Nut committed 8 months ago

the C import line is recommended to be on a separate line
this allows to use the comments in the lines preceeding it
to setup various cpp compiler flags

this also uses cgo comments to pass additional import dirs
for the cpp compiler, these are needed for gopls to work

jkito authored 9 months ago and Pea Nut committed 8 months ago

instead of converting QString to GoString struct which is
error prone, this changes SetTransport and UseLocation in
backend.go to receive a char* as arg, which is  converted
to Go string using the C.GoString helper

this fixes a bug on macOS where changing preference options
did not have any effect as the conversion of string was not
working and empty values were passed to Go functions

0xacab.org/leap/bitmask-core v0.0.0-20240529192952-8ea2f4de269e => 0xacab.org/leap/bitmask-core v0.0.0-20240705122443-e372171b7c36
golang.org/x/sys v0.17.0 => v0.22.0
github.com/rs/zerolog v1.32.0 => v1.33.0
github.com/stretchr/testify v1.8.4 => v1.9.0

this uses $CI_PROJECT_DIR instead of a hardcoded
path for the project's build dir in the arch pkg
job, the hardcoded path doesn't exist if job run
is from a forked repo

jkito authored 9 months ago and jkito committed 9 months ago

this should help with debugging similar bugs which was
fixed in the previous commit

jkito authored 9 months ago and jkito committed 9 months ago

this fixes a bug where StartFirewall is called with an empty
'gateways' slice leading to blocking outgoing connections to
the openvpn gateway

in startOpenvpn func's global scope there's a 'gateways' var
which is passed to FirewallStart and the gateways are  added
to the firewall's allow list of IPs, this was re-declared in
the code branch for non-private bridge which is out of scope
where FirewallStart is called, leading to an empty 'gateways'
slice being passed to it

jkito authored 9 months ago and jkito committed 9 months ago

both the functions are used to start the obfs4 bridge proxy
one using the bridge connection parameters provided via env
another for starting with the parameters received from  the
api

this commit reuses a single function to start the proxy in both
the scenarios

jkito authored 9 months ago and jkito committed 9 months ago

this updates the helpers starting the obfsvpn bridge
to use the new client interface that was  introduced
in obfsvpn 1.0.0

jkito authored 9 months ago and jkito committed 9 months ago

go1.19 is out of support

Pea Nut authored 9 months ago and jkito committed 9 months ago

It does not have a value any more. Directly calling
GatewayPool.GetGatewaysByTimezone instead. Therefore making it public.

Pea Nut authored 9 months ago and jkito committed 9 months ago

It first checks if p.recommended is len=0, then iterates over it.

Pea Nut authored 9 months ago and jkito committed 9 months ago

After removing `Bitmask.ReloadFirewall()` there are no calls to `b.api.GetAllGateways()`
where the calling function actually need the gateways as return values. So I renamed the
function to FetchAllGateways. The function now only returns an error (instead of
`([]bonafide.Gateway, error)`). This simplifies the code of v5 a bit, as
we get rid of yet another function/abstraction. In v3 `gatewayPool.getAll()`
now also returns just an error.

Pea Nut authored 9 months ago and jkito committed 9 months ago

It's never called.

Pea Nut authored 9 months ago and jkito committed 9 months ago

This fixes a small logic error. Each gateway can be multiple times in
p.recommened (for each transport). If a location was selected manually,
each gateway was added twice to the returned list. The returned list is
the list of gateways we will connect to. For more information, please
check: leap/bitmask-vpn!213

- provider is bitmask
- version is current main, as testing latest stable in the CI after
  each commit does not have a real benefit
- Added a new directory ArchLinux (there is already a for directory debian)
- There is a new target `package_arch` to create the Arch package - There is a check before if we are on a Arch System
- I did not add the `package_arch`  to the `packages` target (we can not be an Debian and Arch on the same time)
- `make clean` deletes temporary build files
- Updated .gitignore