kwadronaut authored 8 months ago and jkito committed 8 months ago

we currently have language entries which appears to be repeated
but infact they are different languages, e.g es_AR, es_CU  both
show up as 'Spanish' in the language picker, to make it  easier
to distinguish between them the region is added to the lanugage
picker list, so es_CU now appears as 'Spanish (Cuba)'

Pea Nut authored 8 months ago and jkito committed 8 months ago

Build -> Ubuntu -> Debian -> Arch
From most relevant to least.
The build instructions clarify the PROVIDER env, which is used later in
package_deb.

the post-install tool run by the installer needs to know the path
for the app bundle as the bitmask privilege helper is located  in
the app bundle, earlier it was using a glob pattern "*VPN.app" to
find it, but since in the previous commit the BitmaskVPN name was
dropped and now uses Bitmask instead, this glob pattern no longer
works, so the app name is passed as argument to the tool

this added metadata is used by accessibility tools for
aiding the user to interact with the application

since the application is changed the name is updated
in the README as well to keep the naming consistent

the android app is called as Bitmask, this renames the desktop
app to use the same name and keep the naming consistent across
platforms

this was missed in 37a714e7 where the value of kcp
was written to the config file but during  parsing
the value was not added to the local struct

in b1796790 the config.Provider was changed from the provider
URL to the provider name but the check fetching motd expected
an URL this updates the case statement to match the  provider
name instead of the provider URL

kwadronaut authored 9 months ago and jkito committed 8 months ago

this updates the qt linguist ts files to target the strings
correctly after the recent UI changes

this adds a new boolean "KCP" key to the systray.json
config file

kcp is linked to obfs4, so setting kcp to 'true' sets
obfs4 to also true

since io/ioutil package is deprecated now, this uses
equivalent functions from the os package

this adds a check box to the transport section of
preferences to enable KCP and makes the necessary
updates to SetTransport and GetTransport to allow
KCP to be used as a transport name

the startOpenVPN method fetches gateways for the requested transport
starts the local proxy, sets up firewall and then makes the call  to
start openvpn

this introduces helper methods to perform the preparatory tasks before
openvpn can be started, this makes it easier to navigate the function

jkito authored 8 months ago and jkito committed 8 months ago

This reverts commit 09416b1d.

required pkg-config .pc files are not provided by the qt project
on linux the distribution packages contains them but on  windows
and macOS these are not available causing build to fail

ref: https://bugreports.qt.io/browse/QTBUG-86080

`Quit()` in `main.cpp` calls `Quit()` in `gui/backend.go`
which calls `backend.Quit()` (`defined in pkg/backend/api.go`)

ways to test:
- Preferences -> Quit
- Systray -> Quit
- via signal: killall riseup-vpn

When we exit by Systray/Preferences, `QApplication::quit()` gets called
by `&Backend::quitDone` handler.

cli (cmd/bitmask-helper/main.go and) and helpers (pkg/pickle/helpers.go)
were also fixed.

It only calls vpn.Init()

This was introduced in 970c3f4f where the code supported different api
versions, but there was not yet an implementation for v5.
The apiVersion can be set via env. In the future apiVersion will be
fetched from the API using the /providers.json URL"

It only calls config.ConfigureLogger which now get's called directly.

jkito authored 8 months ago and jkito committed 8 months ago

the $APPNAME is a template variable and replace by the gen-qt-installer
script at build time, which allows to have the correct name of the app
on the error message during uninstall

jkito authored 8 months ago and jkito committed 8 months ago

this adds a custom installer page with a checkbox to allow users to
choose to install the app for all users, when its enabled installer
will create a group called 'OpenVPN Administrator'

local users except the admin, guest and default account are added to
the group, and upon uninstall the group is removed

this allows non-admin users that are added to the group to use the app
and successfully start a vpn connection

jkito authored 8 months ago and Pea Nut committed 8 months ago

this is needed to be passed to be able to build
the GUI since our c-archive libgoshim.a imports
the 'net' package

ref: https://github.com/golang/go/issues/58159
https://tip.golang.org/doc/go1.20#cgo

jkito authored 8 months ago and Pea Nut committed 8 months ago

the C import line is recommended to be on a separate line
this allows to use the comments in the lines preceeding it
to setup various cpp compiler flags

this also uses cgo comments to pass additional import dirs
for the cpp compiler, these are needed for gopls to work

jkito authored 8 months ago and Pea Nut committed 8 months ago

instead of converting QString to GoString struct which is
error prone, this changes SetTransport and UseLocation in
backend.go to receive a char* as arg, which is  converted
to Go string using the C.GoString helper

this fixes a bug on macOS where changing preference options
did not have any effect as the conversion of string was not
working and empty values were passed to Go functions

0xacab.org/leap/bitmask-core v0.0.0-20240529192952-8ea2f4de269e => 0xacab.org/leap/bitmask-core v0.0.0-20240705122443-e372171b7c36
golang.org/x/sys v0.17.0 => v0.22.0
github.com/rs/zerolog v1.32.0 => v1.33.0
github.com/stretchr/testify v1.8.4 => v1.9.0

this uses $CI_PROJECT_DIR instead of a hardcoded
path for the project's build dir in the arch pkg
job, the hardcoded path doesn't exist if job run
is from a forked repo

jkito authored 9 months ago and jkito committed 8 months ago

this should help with debugging similar bugs which was
fixed in the previous commit

jkito authored 9 months ago and jkito committed 8 months ago

this fixes a bug where StartFirewall is called with an empty
'gateways' slice leading to blocking outgoing connections to
the openvpn gateway

in startOpenvpn func's global scope there's a 'gateways' var
which is passed to FirewallStart and the gateways are  added
to the firewall's allow list of IPs, this was re-declared in
the code branch for non-private bridge which is out of scope
where FirewallStart is called, leading to an empty 'gateways'
slice being passed to it