jkito authored 3 months ago and jkito committed 3 months ago

this adds a new error type when app is not able to
get a lock of the pid file as another instance  is
already running, it then shows a msg and quits

jkito authored 4 months ago and jkito committed 3 months ago

during initialization setting ctx.bitmask as soon as vpn.Init()
returns and by not returning error from launcher.FirewallStop
this works around the issue where the app crashes because of calling
methods of the Bitmask object which was nil

the launcher.FirewallStop method returned an error when the helper
was not installed

jkito authored 4 months ago and jkito committed 3 months ago

the status variable was being redeclared inside the
else block which goes out of scope when it returned
leading to returning the wrong status value

this fixes a bug when switching location while still
connected to a gateway as the status was always "Off"
the existing connection was not stopped before trying
to connect to the new gateway

jkito authored 4 months ago and jkito committed 3 months ago

when switching location while still connected Reconnect is
called which tries to stop the connection directly calling
bitmask-root

before trying to stop using bitmask-root try to disconnect
using the management interface like it is done when  users
click disconnect button on the UI

Pea Nut authored 5 months ago and jkito committed 3 months ago

Both must to be done only once.

Pea Nut authored 5 months ago and jkito committed 3 months ago

We access pkBlock.Type later and pkBlock can be nil here.

Pea Nut authored 5 months ago and jkito committed 3 months ago

We've updated bitmask-core. Before the update, DoGeolocationLookup
returned string and error, now it's just an error.

check if the LEAP_INTRODUCER_URL env variable is
non-empty and use its value as introducer URL

this allows us to test the introducer feature in
the client

Pea Nut authored 5 months ago and jkito committed 4 months ago

In case of an error, we try to logDnsLookup(url.Host). url is based on the
provider api url. This can be localhost:8443, so we need to strip the
port :8443 before.

There is also a small change in pkg/vpn/status.go. When using an
introducer, fetching information from menshen can take some time. Then
it can be normal that the call to `GetBestLocation()` fails. This is not
a big deal, as it is called later/periodically. But when we use .Err(),
the output is printed bold to stdout and it looks like there is a big
issue.

to set the required ownership for the bitmask-helper
unix socket we need to fetch the uid and gid of  the
user during installation, this information is  given
by the `id` command and it is needed only on macos

this fixes a bug on windows where installation fails
due to missing the `id` executable on windows

bitmask-vpn installs a daemon called bitmask-helper
which exposes a http api to handle firewall up/down
and openvpn connect/disconnect (only in macos)

this daemon was listening on localhost, since it is
meant to be only accessible to local processes we'v
changed it to listen on a unix domain socket

using unix socket allows to apply file  permissions
and restrict access to the api to only the intended
user

we found a bug on obfsvpn that prevents the app
from being able to connect via bridge a  second
time onwards after disconnecting from the first

ref: obfsvpn#64

Add DoGeolocationLookup implementations (v3 + v5)

- add new fields STUNServers and countryCodeLookupURL in providers/vendor.conf (required for the geolocation lookup)
- load new fields STUNServers and countryCodeLookupURL from providers json
- update gen-providers-json script to support geolocation lookup (the STUN servers should be separated with , in providers/vendor.conf)

- Remove function parseApiURL (was moved to bitmask-core)
- Use NewConfigFromURL instead of NewConfig
- We can still overwrite the API url by setting env API_URL

Adds geolocation lookup feature. Update go version to go 1.22.2 as
bitmask-core uses/needs it.

Nowa Ammerlaan authored 5 months ago and jkito committed 5 months ago

which is an external command, command -v is the equivalent shell built-in.

Replacing the calls to which with command -v removes a build time dependency.

Bug: https://bugs.gentoo.org/940563


Signed-off-by: Nowa Ammerlaan <nowa-ammerlaan@riseup.net>

Pea Nut authored 8 months ago and jkito committed 5 months ago

This prevented VNP working on port 53 because the traffic was redirected
to the DNS server.

Pea Nut authored 8 months ago and jkito committed 5 months ago

We can only iterate once over a generator. After doing, it's like an
empty list. There no real benefit of having it here and we need it in
the future to iterate over the gateways multiple times.

Pea Nut authored 8 months ago and jkito committed 5 months ago

Having a space in Str() is supoptimal:
> DBG Allowd gateway IP gateway ip: =51.158.144.32

jkito authored 7 months ago and jkito committed 5 months ago

this adds a new helper setDefaults() in the config
package and calls it when the config file  doesn't
exist, this provides a way for us to have  default
values for the config options

setDefaults currently only sets the UDP config  to
'true' since it is expected that UDP is enabled by
default

jkito authored 7 months ago and jkito committed 6 months ago

earlier the qmake build always produced the binary named
as bitmask and later it was renamed to whatever PROVIDER
was set to, in the previous commit we fixed the  setting
of TARGET env so that qmake produces the binary with the
correct name

jkito authored 7 months ago and jkito committed 6 months ago

running 'getparam binname' should return the name we want to set
for the qmake TARGET based on the PROVIDER from the  vendor.conf
file, due to running it inside a subshell in make it always gets
the value for the default provider, setting PROVIDER env returns
the correct value

it also updates the qmake project file to use the TARGET env var
and the build script to pass TARGET to qmake command as arg

jkito authored 7 months ago and jkito committed 6 months ago

this allows us to have multiple branded desktop clients installed
along side each other

earlier installing one would uninstall the previous helper as both
used the same name and label for the launchd daemon

jkito authored 7 months ago and jkito committed 6 months ago

qmake is not inheriting the env variables from the parent
process to work around this, it is directly passed as arg
to the qmake invocation