__remove_superficial_meta not working with older Poppler versions

I'm not sure when it happened exactly, but Poppler seems to have removed the Document.set_producer method used by PDFParser.__remove_superficial_meta. I'm using mat2 with Poppler version 0.41.0 and the PDF test is failing because of this.

According to the documentation for python3-gi, this feature is only available starting in version 0.46, yet mat2 only requires version 0.18

I guess the solution is to require 0.46? Or else find some other way of writing these properties...

assigned to @jvoisin

changed milestone to %0.2.0 - Bunny

added good first issue packaging research need labels

You're right, but unfortunately, I can't find a way to specify which Poppler version is required. The git.require_version('Poppler', '0.18') only works to specify the python bindings version.

I need to read more docs about the gobject madness, but help is of course welcome :)

if int(Poppler.get_version().split('.')[1]) < 46:
    raise ValueError("Can't remove superficial metadata with Poppler version earlier than 0.46.0")

Seems to work. I guess something else needs to happen to handle this error at runtime though.

changed title from __remove_superficial_meta not working with newer Poppler versions to __remove_superficial_meta not working with older Poppler versions

Done in f44769df :)

closed

I'm not sure this is the best solution, since the deep cleaning methods will still be useful to users on old Poppler.

Sure, but I don't want to spend time supporting several version of Poppler, and 0.46 was released 2 years ago. MAT2's lower target being Debian stable (that currently ships 0.48 ) so it's ok.

Do you know any widely-used distribution that still ships something below 0.46?

I'm on Linux Mint 18.3 which is currently the latest available version, although it's based on an old version of Ubuntu that's going EOL soon. It still has Poppler 0.43. This probably doesn't matter that much, because Mint 19 is in beta and soon it won't be your problem.

Perfect then

However!

According to the upgrade guide, Mint 18.3 is going to be supported until 2021.

That means a lot of people aren't going to upgrade. Do you want to support them?

It someone is brave enough to package MAT2 for Mint 18.3, I'll be happy to help this person to add a compatibiliy-patch in the package.

I don't want to complicate the codebase for something that ships older packages than Debian stable.

changed milestone to %0.1.3 - ostrich