atenart authored 5 years ago and jvoisin committed 5 years ago

Rework the dependencies definition to include a 'required' flags, which
is passed by the check_dependencies helper to the callers, so that they
can distinguish between required and optional dependencies.

This help in two ways:
- The unit test for the dependencies was now failing when an optional
  one was missing, due to a previous rework.
- Mat2's --check-dependencies was referring to "required dependencies"
  and was misleading for the user as some of them could be optional.

Signed-off-by: Antoine Tenart <antoine.tenart@ack.tf>

atenart authored 5 years ago and jvoisin committed 5 years ago

Remove the try/except logic when calling check_dependencies, as it
cannot throw the exception anymore (it's caught already in the
function).

Signed-off-by: Antoine Tenart <antoine.tenart@ack.tf>

This should ensure that if we decide to implement
some threading in the cli, a faulty file
won't break everything.

- More tests
- More documentation
- Minor code cleanup

This should improve epub compatibility,
along with other formats as a side-effect

This should make easier to get more metadata from
archive-based file formats.

Kudos to Sherry Taylor for reporting this issue 

- This commit introduces optional dependencies (namely ffmpeg):
  mat2 will spit a warning when trying to process an .avi file
  if ffmpeg isn't installed.
- Since metadata are obtained via exiftool, this commit
  also refactors a bit our exfitool wrapper.

Since FLAC files can contain covers, it makes sense
to parse their metadata