Skip to content
Snippets Groups Projects
Commit 7697f9c0 authored by Julien (jvoisin) Voisin's avatar Julien (jvoisin) Voisin
Browse files

Improve the linters' coverage

parent e9200835
No related branches found
No related tags found
No related merge requests found
......@@ -9,6 +9,8 @@ bandit:
script: # TODO: remove B405 and B314
- apt-get -qqy update
- apt-get -qqy install --no-install-recommends python3-bandit
- bandit ./mat2 --format txt
- bandit -r ./nautilus/ --format txt
- bandit -r ./libmat2 --format txt --skip B101,B404,B603,B405,B314
pylint:
......@@ -16,14 +18,16 @@ pylint:
script:
- apt-get -qqy update
- apt-get -qqy install --no-install-recommends pylint3 python3-mutagen python3-gi-cairo gir1.2-poppler-0.18 gir1.2-gdkpixbuf-2.0
- pylint3 --extension-pkg-whitelist=cairo,gi ./libmat2
- pylint3 --extension-pkg-whitelist=cairo,gi ./libmat2 ./mat2
# Once nautilus-python is in Debian, decomment it form the line below
- pylint3 --extension-pkg-whitelist=Nautilus,GObject,Gtk,Gio,GLib,gi ./nautilus/nautilus_mat2.py
pyflakes:
stage: linting
script:
- apt-get -qqy update
- apt-get -qqy install --no-install-recommends pyflakes3
- pyflakes3 ./libmat2 ./mat2 ./tests/
- pyflakes3 ./libmat2 ./mat2 ./tests/ ./nautilus
mypy:
stage: linting
......@@ -32,6 +36,7 @@ mypy:
- apt-get -qqy install --no-install-recommends python3-pip
- pip3 install mypy
- mypy mat2 libmat2/*.py --ignore-missing-imports
- mypy --ignore-missing-imports ./nautilus/nautilus_mat2.py
tests:debian:
stage: test
......
......@@ -16,7 +16,7 @@ except ValueError as e:
__version__ = '0.2.0'
def __check_file(filename: str, mode: int = os.R_OK) -> bool:
def __check_file(filename: str, mode: int=os.R_OK) -> bool:
if not os.path.exists(filename):
print("[-] %s is doesn't exist." % filename)
return False
......@@ -37,7 +37,7 @@ def create_arg_parser():
parser.add_argument('-l', '--list', action='store_true',
help='list all supported fileformats')
parser.add_argument('-c', '--check-dependencies', action='store_true',
help='check if MAT2 has all the dependencies it needs')
help='check if MAT2 has all the dependencies it needs')
info = parser.add_mutually_exclusive_group()
......
#!/usr/bin/env python3
# pylint: disable=unused-argument,len-as-condition,arguments-differ
# pylint: disable=unused-argument,arguments-differ,no-self-use,no-name-in-module,import-error
"""
Because writing GUI is non-trivial (cf. https://0xacab.org/jvoisin/mat2/issues/3),
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment