Skip to content
Snippets Groups Projects
  1. Apr 30, 2016
    • ulif's avatar
      Update history. · 88f049d9
      ulif authored
      88f049d9
    • ulif's avatar
      More kudos to @dwcoder · 0fbe13f4
      ulif authored
      0fbe13f4
    • ulif's avatar
      Merge branch 'dwcoder-fix-iss21' · ceefc71e
      ulif authored
      ceefc71e
    • ulif's avatar
      Undo changes to "considers_configfile" tests. · 3cbbc449
      ulif authored
      The modifications undone here, in
      `test_handle_options_considers_configfile()` could have gone into an
      own test. Each single test should only test a clear minimum of
      things.
      
      This specific test checked, whether configiles are considered at
      all. It was not its purpose to examine correct interpretation of
      keywords in the .ini-file; only to see whether these keyword values
      can be changed at all.
      
      If we wanted a complete and strict checking also of values, we had at
      least to check all possible keywords, including 'randomsource' and
      'wordlist'. Instead we only check a boolean, int, and string type
      keyword.
      
      Therefore the change to `test_handle_options_considers_configfile()`
      should have gone to another test.
      
      But then, the added testing is not neccessary. We had a test already
      that should have checked the 'caps' value properly. This test was done
      wrong before and is now done correctly, thanks to @dwcoder .
      
      I therefore removed the added test functionality.
      3cbbc449
    • ulif's avatar
      pep8. · dd1f56af
      ulif authored
      Running `pep8` or `flake8` over `tests/` complained about this one
      blank line.
      dd1f56af
  2. Apr 29, 2016
    • dwcoder's avatar
      Change capitalize to caps · 81d83afe
      dwcoder authored
      This commit fixes issue #21.
      Change all occurences of the option `capitalize` to `caps` in
      __init.py__.
      
      Make the same change in the test_diceware.py.
      Add a unit test that checks the output of main() after setting the
      `caps = off` in the .diceware.ini.
      81d83afe
  3. Apr 28, 2016
  4. Apr 27, 2016
  5. Apr 25, 2016
    • ulif's avatar
      Provide a logger, API-wise. · 70f91b65
      ulif authored
      Add a common place where components can write messages to. Any
      userinterface can decide, what messages should be visible
      (depending on their severity).
      70f91b65
  6. Apr 24, 2016
  7. Apr 21, 2016
  8. Apr 20, 2016
  9. Apr 19, 2016
    • dwcoder's avatar
      Put calculations in right place · a08516d7
      dwcoder authored
      Move the calculations out of the `pre_check()` function.
      Also do smarter checks:
        - If len(sequence) == 1, we don't need any rolls. In this case, just
          return sequence[0]
        - If len(sequence) is a factor of dice_sides, we only need one roll
          along with the modulo operator.
        - For everything else, just require one extra roll, bringing it to a
          total of 2 rolls. This should remove a little bit of the edge bias
          introduced by the modulo
      Run the `pre_check()` function after the calculations have been done.
      
      For the unit tests:
        - remove the function `test_choice_len_too_short()`;
          we no longer have to raise an exception when the sequence length is
          too short.
        - Write new tests for the cases where `dice_sides = 6` and `len(sequence)`:
           - 1
           - 2,3
           - 4,5
      a08516d7
  10. Apr 17, 2016
  11. Apr 16, 2016
Loading