-
- Downloads
Undo changes to "considers_configfile" tests.
The modifications undone here, in `test_handle_options_considers_configfile()` could have gone into an own test. Each single test should only test a clear minimum of things. This specific test checked, whether configiles are considered at all. It was not its purpose to examine correct interpretation of keywords in the .ini-file; only to see whether these keyword values can be changed at all. If we wanted a complete and strict checking also of values, we had at least to check all possible keywords, including 'randomsource' and 'wordlist'. Instead we only check a boolean, int, and string type keyword. Therefore the change to `test_handle_options_considers_configfile()` should have gone to another test. But then, the added testing is not neccessary. We had a test already that should have checked the 'caps' value properly. This test was done wrong before and is now done correctly, thanks to @dwcoder . I therefore removed the added test functionality.
Please register or sign in to comment