This removes a dependency by using the built-in go:embed functionality
introduce in Go 1.16 instead of statik for embedding files.
This means that Go 1.16+ would now be required to build the VPN.

Signed-off-by: Sam Whited <sam@samwhited.com>

Previously we saved the vendor tree in version control, making any
commit that changed a dependency rather large.
Go Modules gives us most of the advantages of vendoring except that if a
dependency which is not stored on the proxy is deleted we would lose
access to it.
For now, we can remove the vendor tree and when we get CI working again
we can possibly generate and save the vendor tree as a build artifact.

Signed-off-by: Sam Whited <sam@samwhited.com>

Sam Whited authored 3 years ago and Kali Kaneko committed 3 years ago

kali was sloppy leaving that there

Sam Whited authored 3 years ago and Kali Kaneko committed 3 years ago

Removes some GNUisms in favor of POSIX-make or generally more portable
make constructs.

Signed-off-by: Sam Whited <sam@samwhited.com>

Nil slices are valid slices of length 0, so the nil check is not needed.

Signed-off-by: Sam Whited <sam@samwhited.com>

until we include a language switcher, this is how we can test
translations.

this was failing for non-en locales

- Resolves: #590

aboutToQuit let us catch Quits coming from the osx menu or the dock.

Kali Kaneko authored 3 years ago and Kali Kaneko committed 3 years ago

- binary name is different in the osx bundle, theme won't load
- calyx is not ready for tls 1.2 yet

kali authored 3 years ago and Kali Kaneko committed 3 years ago

A vulnerability in QtIFW produces improper ACLs to be set when
installing in custom locations. This can lead to privilege escalation if
a non-privileged user overwrites the openvpn binary. Thanks to
researchers at Tenable for finding and reporting this!

Impact is considered low-medium, since an installation outside of the
suggested path is needed to trigger the issue.

Privileged execution of openvpn should be abandoned in next release, in
favor of the interactive service.

A bug upstream should be filed since other projects could be affected by
this vulnerability too.

-Resolves: #569

-QApplication, no QGuiApplication: the later avoids the systray to
display
- Workaround for invisible app icons when vendoring
- Make border visible for snaps

this is an attempt to solve the problem we're having with snaps, in
which Overlays are not correctly displayed.