-
- Downloads
[329] refactor `sdMessageOf`
* instead of taking unnamed `channel` and `mesageBody` take named `sender`, `recipient`, `message` and `attachments` * motivation: simplifies the contract of `signal.sendMessage`, enables cleaner marshalling of `notification`s to be passed to `sendMessage`, is generally easier to read and clearer about the "outbound" cardinality of any and all sdMessages we ever construct
Showing
- app/diagnostics.js 5 additions, 5 deletionsapp/diagnostics.js
- app/dispatcher/messenger.js 16 additions, 10 deletionsapp/dispatcher/messenger.js
- app/dispatcher/resend.js 1 addition, 1 deletionapp/dispatcher/resend.js
- app/notifier.js 5 additions, 4 deletionsapp/notifier.js
- app/registrar/channel.js 13 additions, 10 deletionsapp/registrar/channel.js
- app/registrar/safetyNumbers.js 6 additions, 6 deletionsapp/registrar/safetyNumbers.js
- app/signal/callbacks.js 2 additions, 1 deletionapp/signal/callbacks.js
- app/signal/constants.js 12 additions, 4 deletionsapp/signal/constants.js
- app/signal/index.js 8 additions, 17 deletionsapp/signal/index.js
- test/integration/diagnostics.spec.js 7 additions, 0 deletionstest/integration/diagnostics.spec.js
- test/integration/dispatcher.spec.js 19 additions, 16 deletionstest/integration/dispatcher.spec.js
- test/support/util.js 0 additions, 5 deletionstest/support/util.js
- test/unit/diagnostics.spec.js 5 additions, 2 deletionstest/unit/diagnostics.spec.js
- test/unit/dispatcher/commands/execute.spec.js 94 additions, 46 deletionstest/unit/dispatcher/commands/execute.spec.js
- test/unit/dispatcher/messenger.spec.js 58 additions, 22 deletionstest/unit/dispatcher/messenger.spec.js
- test/unit/dispatcher/resend.spec.js 2 additions, 8 deletionstest/unit/dispatcher/resend.spec.js
- test/unit/notifier.spec.js 59 additions, 20 deletionstest/unit/notifier.spec.js
- test/unit/registrar/channel.spec.js 15 additions, 6 deletionstest/unit/registrar/channel.spec.js
- test/unit/registrar/safetyNumbers.spec.js 12 additions, 8 deletionstest/unit/registrar/safetyNumbers.spec.js
- test/unit/signal/callbacks.spec.js 4 additions, 1 deletiontest/unit/signal/callbacks.spec.js
Loading
Please register or sign in to comment