Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
signalboost
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
team-friendo
signalboost
Merge requests
!522
[hf] omit subscriber count in INFO response to randos
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
[hf] omit subscriber count in INFO response to randos
hf-omit-subscriber-count-from-info-response-to-randos
into
main
Overview
0
Commits
1
Pipelines
1
Changes
1
Merged
aguestuser
requested to merge
hf-omit-subscriber-count-from-info-response-to-randos
into
main
4 years ago
Overview
0
Commits
1
Pipelines
1
Changes
1
Expand
we used to show subscriber counts in
INFO
responses for all users
we removed this (potentially sensitive) data from responses for subscribers but forgot to omit it for non-subscribed users
this MR fixes that by also omiting the subscriber count for
INFO
responses to randos
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
3230e10e
1 commit,
4 years ago
1 file
+
1
−
4
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
app/dispatcher/strings/messages/EN.js
+
1
−
4
Options
@@ -227,10 +227,7 @@ ${support}`,
CHANNEL INFO
---------------------------
You are not subscribed to this channel. Send HELLO to subscribe.
phone number:
${
channel
.
phoneNumber
}
subscribers:
${
getSubscriberMemberships
(
channel
).
length
}
You are not subscribed to channel
${
channel
.
phoneNumber
}
. Send HELLO to subscribe.
${
support
}
`
,
},
Loading