Skip to content

Resolve "BUG: admins sending messages disables disappearing message timer"

Closes #356 (closed)

bugfix

  • SYMPTOM: admin sending message with disappearing message set to any non-zero value will turn disappearing messages off (always)
  • CAUSE:
    • for whatever reason, signald now relays normal text messages with the expiresInSeconds fields incorrectly set to 0
    • this was triggering dispatcher.detectUpdatableExpiryTime to think it was handling a setExpiry message (when in fact it was not)
  • FIX:
    • modify detectUpdatableExpiryTime to exclude any message with a non-empty body or attachments fields for consideration as an expiry time udpate message (which works b/c since all true expiry time update messages have empty bodies)

dependency udpate

match upstream master signald build (as of 2020-10-25 | MR 29):

91da2590

Merge request reports