Skip to content
Snippets Groups Projects

[hf] pass in socketId to signal.subscribe & signal.setExpiration

Merged Mari requested to merge hf-use-0-as-socketId-for-new-channels into main

BUG: creating new channels threw an error TypeError: Cannot read property 'acquire' of undefined

This was because the socketId is undefined when creating a new channel, when it should be 0 (b/c a new channel is guaranteed (by grouping algo in socket.sharding.groupEvenly) to be the shard with the smallest current number of subscribers.)

In the process, I discovered a similar bug in signal.setExpiration.

Fix:

  • set socketId to 0 in channel.create
  • pass in socketId to all instances of signal.setExpiration.

Merge request reports

Merge request pipeline #47914 passed

Merge request pipeline passed for 43eb2f82

Merged by aguestuseraguestuser 4 years ago (Oct 23, 2020 12:35am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading