[hf] pass in socketId to signal.subscribe & signal.setExpiration
BUG: creating new channels threw an error TypeError: Cannot read property 'acquire' of undefined
This was because the socketId
is undefined when creating a new channel, when it should be 0
(b/c a new channel is guaranteed (by grouping algo in socket.sharding.groupEvenly
) to be the shard with the smallest current number of subscribers.)
In the process, I discovered a similar bug in signal.setExpiration
.
Fix:
- set socketId to 0 in
channel.create
- pass in socketId to all instances of
signal.setExpiration
.
Merge request reports
Activity
Filter activity
Please register or sign in to reply