Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
signalboost
signalboost
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 110
    • Issues 110
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • team-friendo
  • signalboostsignalboost
  • Merge Requests
  • !387

Merged
Opened Sep 11, 2020 by aguestuser@aguestuserOwner

[hotfix] actually send broadcast messages in sequence

  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2
  • we introduced a fix a long time ago to send broadcast messages in sequence on the theory that (1) this would jam up signald's concurrency bugs less and (2) we had observed health checks fail less and transmit faster when sent in sequence
  • however, we did not notice that broadcastMessage was only ever being called with one recipient (presumably to get per-recipient language choices honored) so we were never actually sending such messages in sequence
  • @mari has a more comprehensive fix coming in #329 (closed), but until it lands, here is a small patch to make sure broadcast messages actually go out in sequence so we can measure if this makes any kind of difference in perf/reliability
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: team-friendo/signalboost!387
Source branch: hotfix-actually-send-broadcasts-in-sequence

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.