[#337] Resolve "hard code port numbers in docker-compose configs"
Closes #337 (closed) Closes #334 (closed)
context
- in a half-hearted attempt at creating a "single source of truth" for port numbers that needed to be referenced in more an more places in our docker configs, we extracted a
SIGNALD_PORT
andSIGNALBOOST_PORT
into.env
and.env.dev
respectively - this didn't help all that much and created some confusion in causing backups to fail (b/c env file not included -- b/c not needed -- in backup script) and new devs to be unable to startup the app (see #334 (closed) )
changes
- since it's not that helpful, let's just hardcode these ports everywhere we need them.
- if this becomes a problem, we can come up with a more elegant solution than treating ports like encrypted credentials somewhere down the line (likely using yaml anchor snippets)
side effects
while we're sprucing up the configs, lets:
- include diagnostics channel in example env files
- cleanup splash back docker-compose up/down commands
- fix a bug in the backup script (referencing
pwd
instead of$(pwd)
causing a halting error
Edited by aguestuser