Skip to content

[hotfix] inject .env file into signald container

aguestuser requested to merge hotfix-inject-env-file-into-signald-container into master

fixes the following bug in !335 (merged) in a way designed to prevent similar easy-to-make mistakes from recurring..

  • SYMPTOM: shipped new data dog instrumentation in signald entrypoint that should only run in prod, but it did not run in prod
  • CAUSE: the SIGNALBOOST_ENVRIONMENT env var being inspected for whether or not we were in prod was not set b/c it is defined in .env which is not available to the signald container
  • FIX: inject .env and .env.dev into the prod and dev signald containers (respectively) so that this bug won't happen and future devs may safely assume that any env vars defined in env file are available in signald container

--

cc @fdbk

Merge request reports

Loading