Skip to content

[#246] fix bug prevening hotline replies to non-subscribers

aguestuser requested to merge 246-bug-cannot-reply-to-hotline-message-from-non-subscribers into master

Closes #246 (closed)

  • SYMPTOM: when trying to send a hotline reply to a non-subscriber, admins get an invalid message id error ("Sorry, the hotline message identifier #${messageId} has expired or never existed.``" (even though there is in fact a message id for the given combination of sender phone number and channel
  • CAUSE: the code for generating hotline replies assumes that the sender must have membership on the channel (which it does so that it can use the membership's language for the message header), and throws an error if it cannot find a membership
  • FIX: pass a default language for non-subscribers if no membership can be found, and don't throw

Merge request reports