Skip to content

[hotfix] don't return early after handling expiry time udpates

aguestuser requested to merge hotfix-ignore-expiry-time-updates-from-randos into master
  • BUG SYMPTOM: users attempting to subscribe to newly created channels (with disappearing messages) enabled have HELLO and INFO commands dumped, and thus nobody can subscribe to the channel
  • CAUSE: most first-ever messages from unsubscribed users habe expiry time 0. because of this, the detectNewExpiryTime subroutine of dispatch treats this message as an attempt to reset the disappearing message timer, which it handles by ignoring the request to reset and returning early. (As it does for all messages that it interprets as requests to reset the message timer.) Thus, shouldRelay is never called, and the HELLO command is never processed (or even considered for processing). (Likewise: no first-time messages from any user on a channel with disappearing messages enabeled would ever be successfully processed. We didn't notice this before b/c the bug that @aguestuser fixed in !193 (merged) was causing disappearing messages to never actually be enabled!)
  • FIX: don't ever return early after handling an expiry time update request!

Merge request reports