Skip to content

[hotfix] fix bug causing rate-limit resends with attachments to fail

aguestuser requested to merge ni-fix-bug-in-resending-rate-limited-messages-with-attachments into master
  • SYMPTOM: halting error when attempting to resend a rate-limited message that contained attachment. crashes due to deserialization error with message: "Cannot deserialize instance of java.lang.String out of START_OBJECT token"
  • CAUSE: we were failing to transform attachments from their inbound format to their outbound format (and yes, it's annoying that signald uses a different format for inboud and outbound attachments!)
  • FIX: parse outbound attachments the first time we resend a message and alter the hashing algorithm such that it hashes a field that is not removed during that parse step (ie: use the filename,not the digest)

Merge request reports