Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
signalboost
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
team-friendo
signalboost
Merge requests
!144
[hotfix] fix bug causing channel-creation notifications to not send
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
[hotfix] fix bug causing channel-creation notifications to not send
ns-fix-notify-after-channel-creation-bug
into
master
Overview
0
Commits
1
Pipelines
0
Changes
4
Merged
aguestuser
requested to merge
ns-fix-notify-after-channel-creation-bug
into
master
5 years ago
Overview
0
Commits
1
Pipelines
0
Changes
4
Expand
SYMPTOM: after creating a channel, admins don't get a notificatino
CAUSE: we changed the signature for
notify
and modified it for all callers in
dispatcher.messenger
but not in
registar.channel
FIX:
modify the signature to use keyword args for slightly increased safety
use the same signature everywhere
0
0
Merge request reports
Activity
All activity
Filter activity
Deselect all
Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking
Loading
Loading
Please
register
or
sign in
to reply
Loading