Commit 2c3584ca authored by taggart's avatar taggart
Browse files

add some comments/fixes from review with micah

parent ccc37457
......@@ -27,6 +27,7 @@ class sympa::debian {
}
}
# move these to dirs
class sympa::fastcgi::debian {
package {
[ libapache2-mod-fastcgi, libcgi-fast-perl ]:
......
......@@ -25,9 +25,6 @@ class sympa::fastcgi {
apache2::module {
"fastcgi": ensure => present, require_package => "libapache2-mod-fastcgi";
# we need a way to set things in fcgid.conf, but the apache2 module
# we're currently (Aug 2011) using doesn't support that, so we deliver
# it as a file below
"fcgid": ensure => absent;
}
......
......@@ -10,17 +10,18 @@ class sympa::fcgid {
# we're currently (Aug 2011) using doesn't support that, so we deliver
# it as a file below
"fcgid": ensure => present, require_package => "libapache2-mod-fcgid";
# disable fastcgi FIXME: too much?
"fastcgi": ensure => absent;
}
# FIXME: this is Riseup specific, figure out where to move it
file {
# NOTE: as mentioned above it would be better if the apache2 module
# could handle setting things in the module conf files for us, but for
# now we just deliver the file
# FIXME: a newer augeas supports making the changes that this file delivers
# move to it once we have it backported
"/etc/apache2/mods-available/fcgid.conf":
source => "$fileserver/apache2/fcgid.conf",
owner => root, group => root, mode => 0644;
}
}
......@@ -3,9 +3,10 @@ class sympa {
case $operatingsystem {
debian: { include sympa::debian }
mageia: { include sympa::mageia }
default: { include sympa::default }
default: { err("This operating system not supported") }
}
#FIXME: globals suck, use the right method (see the dovecot module)
if $use_munin { include sympa::munin }
if $use_nagios { include sympa::nagios }
......
# FIXME: maybe this shouldn't be in the sympa class?
class sympa::samilter {
case $operatingsystem {
debian: { include sympa::samilter::debian }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment