Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
backupninja
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
raT
backupninja
Commits
26e33dcc
Commit
26e33dcc
authored
18 years ago
by
intrigeri
Browse files
Options
Downloads
Patches
Plain Diff
ninjahelper.in: remove runtime overzealous perms checks on the helpers
parent
c836982f
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
ChangeLog
+4
-0
4 additions, 0 deletions
ChangeLog
src/ninjahelper.in
+0
-18
0 additions, 18 deletions
src/ninjahelper.in
with
4 additions
and
18 deletions
ChangeLog
+
4
−
0
View file @
26e33dcc
...
...
@@ -85,6 +85,10 @@ version 0.9.4 -- unreleased
. Fix configdirectory error that forced you to use /etc/backup.d, thanks anarcat
. When determining which backup actions to list, find now follows
symlinks for $configdirectory
. Stop checking helpers perms: both "make install" and distros packages
install them with appropriate permissions, it's overzealous to check
this at runtime, and is more complicated to do with current
admingroup option.
dup.helper:
. Fix: signing was enabled with symmetric encryption.
changed cron permissions to 644
...
...
This diff is collapsed.
Click to expand it.
src/ninjahelper.in
+
0
−
18
View file @
26e33dcc
...
...
@@ -4,23 +4,6 @@
####################################################
## Functions
function
check_perms
()
{
local
file
=
$1
local
perms
=
`
ls
-ld
$file
`
group_w_perm
=
${
perms
:5:1
}
world_w_perm
=
${
perms
:8:1
}
if
[
"
$group_w_perm
"
==
"w"
-o
"
$world_w_perm
"
==
"w"
]
;
then
echo
$perms
echo
"helper scripts must not be group or world writable! Dying on file
$file
"
exit
fi
if
[
`
ls
-ld
$file
|
awk
'{print $3}'
`
!=
"root"
]
;
then
echo
"helper scripts must be owned by root! Dying on file
$file
"
exit
fi
}
##
## returns the next available file name given a file
## in the form @CFGDIR@/backup.d/10.sys
...
...
@@ -238,7 +221,6 @@ getconf scriptdirectory @datadir@
# load all the helpers
HELPERS
=
""
for
file
in
`
find
$scriptdirectory
-follow
-name
'*.helper'
`
;
do
check_perms
$file
.
$file
if
[
$?
!=
0
]
;
then
echo
"An error occurred while loading
$file
. Hit return to continue."
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment