There's some corner cases that were very badly captured. On the first
place, it's confusing to quit on connection errors.

Secondly, a side-effect of aborting the initialization of the bitmask
object was a semi-random segfault when trying to access the object.

Here I pass any connection errors to the gui, but leave to the user to
quit the app. This probably will need more work when we want to
terminate the app on unrecoverable errors (no polkit, etc...), but for
now it makes the systray much more usable.

- Resolves: #465

Kali Kaneko authored 4 years ago and meskio committed 4 years ago

a rather annoying bug, since it keeps popping up for every status
change. to be included in a hotfix for 0.21.2 release.

- Release: 0.21.2
- Closes: #459

10 seconds might be too low nowadays when accessed from some regions.

- Related: #463

- Closes: #436

- remove unused debug
- uncomment notification function, leftover from debug
- comment about go-land mutexes

Kali Kaneko authored 4 years ago and Kali Kaneko committed 4 years ago

this is a regression that was introduced with previous changes to the
menus in windows. activation segfaults in linux and osx, so capture the event
only for windows. did not investigate further about the causes, but it seems
like a good workaround for the time being.

kali authored 4 years ago and Kali Kaneko committed 4 years ago

squashed in this commit: reintroduce the dummy autostart_win implementation that was
removed by mistake. I did not manage to get autostart working in
windows, this is pending to be re-worked. see #389

- Resolves: #374

config.BinaryName is not set when the global variables are defined, we
need to generate the string when we need it instead.

kali authored 4 years ago and meskio committed 4 years ago

Several fixes for missing paths. Refactor qt installer; fetch pre-built
binaries from an existing installation on build system (needs to be
automated); add windows icon.

- Resolves: #362

- Resolves: #358

it seems this was an attempt to make this injectable for tests, but it
can work by changing config variables too.

- Resolves: 336

- add some extra debug info for troubleshooting start errors
- fix vendors labels

Also disable autostart if manual quit, remove custom printer that was
used for i18n and disable previous autostart if -disable-autostart

We didn't disable autostart after the migration to qt.

- Resolves: #355 #289

meskio authored 4 years ago and Kali Kaneko committed 4 years ago

A corrupted pid file, or a file that contains something else than a pid
number used to block bitmask-vpn from launch. Now if the file contains
something that is not expected it will log it and rewrite it.

I refactor de code so the pid file will be released on quit instead of
initialization.

- Resolves: #349

- Resolves: #326