[bug] use the right http client to fetch the auth

pkg/vpn/bonafide/auth_anon.go

@@ -19,9 +19,7 @@ import (
 	"errors"
 )
 
-type anonymousAuthentication struct {
-	client httpClient
-}
+type anonymousAuthentication struct{}
 
 func (a *anonymousAuthentication) needsCredentials() bool {
 	return true

pkg/vpn/bonafide/auth_sip.go

@@ -19,7 +19,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
-	"net/http"
 	"strings"
 )
 
@@ -41,7 +40,7 @@ func (a *sipAuthentication) getToken(user, password string) ([]byte, error) {
 	if err != nil {
 		return nil, fmt.Errorf("Cannot encode credentials: %s", err)
 	}
-	resp, err := http.Post(a.authURI, "text/json", strings.NewReader(credJSON))
+	resp, err := a.client.Post(a.authURI, "text/json", strings.NewReader(credJSON))
 	if err != nil {
 		return nil, fmt.Errorf("Error on auth request: %v", err)
 	}

pkg/vpn/bonafide/bonafide.go

@@ -105,10 +105,10 @@ func New() *Bonafide {
 		b.auth = &sipAuthentication{client, b.getURL("auth")}
 	case "anon":
 		log.Println("Client expects anon auth")
-		b.auth = &anonymousAuthentication{client}
+		b.auth = &anonymousAuthentication{}
 	default:
 		log.Println("Client expects invalid auth", auth)
-		b.auth = &anonymousAuthentication{client}
+		b.auth = &anonymousAuthentication{}
 	}
 
 	return b