-
- Downloads
test: use advanced fixtures
Also added an extension to ActiveRecord::FixtureSet that will add timestamps to autogenerated join records. https://github.com/rails/rails/pull/21337 inspired this. Our own implementation differs significantly though. :sphinx: turn access_ids index into bigints these are also integers with number prefixes. Pitty that this will increase the index size considerably Add council fixture test: ensure that group wiki creation is forbidden for non council members add fixtures for a groupwithcouncil add a test for wiki editing without council powers remove versioning test test: do not delete pages from sphinx index Remove a test that would delete a task list page from the fixtures. Transactional fixtures restore the page but the entry in the sphinx index is not restored. This lead to inconsistencies between sphinx and sql. I'm not sure how to properly fix this. Here's a few ideas: 1) reindex sphinx before or after test runs. Sphinx claims to take 0.005 seconds to index the few pages we have in the fixtures 2) create the page that we want to delete in the test itself 3) reindex sphinx between runs of different suites The page is deleted in a pages:unit test. The failing tests are part of the core tests. 3) seems like a bad idea as it only works if page and core tests are run separately. 2) seems cumbersome. Plus we should be able to delete fixtures without thinking about such things. 1) seems preferable. test: fix brittle tests * Make sure animals are in the right order to pick Iguana from the top of the page. * Use a Wiki page to test the comments inclusion in page_terms. Discussion Page will store them as body_content rather than comments.
Showing
- app/indices/page_terms_index.rb 1 addition, 1 deletionapp/indices/page_terms_index.rb
- app/models/page/comments.rb 0 additions, 2 deletionsapp/models/page/comments.rb
- app/models/user/users.rb 1 addition, 2 deletionsapp/models/user/users.rb
- app/policies/group_policy.rb 0 additions, 12 deletionsapp/policies/group_policy.rb
- db/migrate/20190523223316_update_castle_gate_keys_holder_code_size.rb 13 additions, 0 deletions...0190523223316_update_castle_gate_keys_holder_code_size.rb
- db/migrate/20190523223739_update_page_terms_owner_id_size.rb 13 additions, 0 deletionsdb/migrate/20190523223739_update_page_terms_owner_id_size.rb
- db/schema.rb 3 additions, 3 deletionsdb/schema.rb
- extensions/pages/task_list_page/app/controllers/tasks_controller.rb 1 addition, 1 deletion.../pages/task_list_page/app/controllers/tasks_controller.rb
- extensions/pages/task_list_page/test/functional/tasks_controller_test.rb 26 additions, 2 deletions...s/task_list_page/test/functional/tasks_controller_test.rb
- extensions/pages/task_list_page/test/unit/task_list_page_test.rb 1 addition, 8 deletions...ons/pages/task_list_page/test/unit/task_list_page_test.rb
- extensions/pages/wiki_page/test/integration/collaboration_test.rb 1 addition, 1 deletion...ns/pages/wiki_page/test/integration/collaboration_test.rb
- lib/extends/active_record.rb 58 additions, 0 deletionslib/extends/active_record.rb
- lib/tasks/fixtures.rake 2 additions, 0 deletionslib/tasks/fixtures.rake
- test/fixtures/acts_as_taggable_on/taggings.yml 4 additions, 4 deletionstest/fixtures/acts_as_taggable_on/taggings.yml
- test/fixtures/castle_gates/keys.yml 29 additions, 119 deletionstest/fixtures/castle_gates/keys.yml
- test/fixtures/discussions.yml 17 additions, 17 deletionstest/fixtures/discussions.yml
- test/fixtures/group/federatings.yml 16 additions, 16 deletionstest/fixtures/group/federatings.yml
- test/fixtures/group/memberships.yml 0 additions, 192 deletionstest/fixtures/group/memberships.yml
- test/fixtures/group/participations.yml 24 additions, 33 deletionstest/fixtures/group/participations.yml
- test/fixtures/groups.yml 28 additions, 29 deletionstest/fixtures/groups.yml
Loading
Please register or sign in to comment