Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
cicer
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
meskio
cicer
Commits
1a205c51
Commit
1a205c51
authored
4 years ago
by
meskio
Browse files
Options
Downloads
Patches
Plain Diff
Be able to set login on password reset
parent
6f236cb0
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
api/auth.go
+8
-2
8 additions, 2 deletions
api/auth.go
api/db/member.go
+2
-7
2 additions, 7 deletions
api/db/member.go
api/member.go
+1
-1
1 addition, 1 deletion
api/member.go
src/Panel.js
+0
-3
0 additions, 3 deletions
src/Panel.js
src/ResetPassword.js
+10
-5
10 additions, 5 deletions
src/ResetPassword.js
with
21 additions
and
18 deletions
api/auth.go
+
8
−
2
View file @
1a205c51
...
...
@@ -130,7 +130,7 @@ func (a *api) SendPasswordReset(w http.ResponseWriter, req *http.Request) {
func
(
a
*
api
)
ValidatePasswordReset
(
w
http
.
ResponseWriter
,
req
*
http
.
Request
)
{
vars
:=
mux
.
Vars
(
req
)
token
:=
vars
[
"token"
]
err
:=
a
.
db
.
Valid
PasswordReset
(
token
)
passwordReset
,
err
:=
a
.
db
.
Get
PasswordReset
(
token
)
if
err
!=
nil
{
log
.
Printf
(
"Can't get password reset %s: %v"
,
token
,
err
)
if
errors
.
Is
(
err
,
db
.
ErrorNotFound
)
{
...
...
@@ -141,8 +141,14 @@ func (a *api) ValidatePasswordReset(w http.ResponseWriter, req *http.Request) {
return
}
w
.
Header
()
.
Set
(
"Content-Type"
,
"application/json"
)
w
.
WriteHeader
(
http
.
StatusOK
)
w
.
Write
([]
byte
(
"Valid token"
))
err
=
json
.
NewEncoder
(
w
)
.
Encode
(
*
passwordReset
.
Member
)
if
err
!=
nil
{
log
.
Printf
(
"Can't encode member: %v"
,
err
)
w
.
WriteHeader
(
http
.
StatusInternalServerError
)
return
}
}
func
(
a
*
api
)
PasswordReset
(
w
http
.
ResponseWriter
,
req
*
http
.
Request
)
{
...
...
This diff is collapsed.
Click to expand it.
api/db/member.go
+
2
−
7
View file @
1a205c51
...
...
@@ -156,13 +156,8 @@ func (d DB) NewPasswordReset(email string) (member Member, token string, err err
return
}
func
(
d
*
DB
)
ValidPasswordReset
(
token
string
)
error
{
_
,
err
:=
d
.
getPasswordReset
(
token
)
return
err
}
func
(
d
*
DB
)
ResetPassword
(
token
,
password
,
login
string
)
error
{
passwordReset
,
err
:=
d
.
g
etPasswordReset
(
token
)
passwordReset
,
err
:=
d
.
G
etPasswordReset
(
token
)
if
err
!=
nil
{
return
err
}
...
...
@@ -186,7 +181,7 @@ func (d *DB) ResetPassword(token, password, login string) error {
})
}
func
(
d
*
DB
)
g
etPasswordReset
(
token
string
)
(
passwordReset
PasswordReset
,
err
error
)
{
func
(
d
*
DB
)
G
etPasswordReset
(
token
string
)
(
passwordReset
PasswordReset
,
err
error
)
{
err
=
d
.
db
.
Where
(
"token = ?"
,
token
)
.
Preload
(
"Member"
)
.
First
(
&
passwordReset
)
.
Error
...
...
This diff is collapsed.
Click to expand it.
api/member.go
+
1
−
1
View file @
1a205c51
...
...
@@ -33,7 +33,7 @@ func (a *api) AddMember(w http.ResponseWriter, req *http.Request) {
w
.
WriteHeader
(
http
.
StatusInternalServerError
)
return
}
err
=
a
.
mail
.
sendNewMember
(
memberReq
.
Member
,
"/
n
reset/"
+
token
)
err
=
a
.
mail
.
sendNewMember
(
memberReq
.
Member
,
"/reset/"
+
token
)
if
err
!=
nil
{
log
.
Printf
(
"Can't send the pass/login reset email to %s: %v"
,
memberReq
.
Email
,
err
)
w
.
WriteHeader
(
http
.
StatusInternalServerError
)
...
...
This diff is collapsed.
Click to expand it.
src/Panel.js
+
0
−
3
View file @
1a205c51
...
...
@@ -87,9 +87,6 @@ function UnlogedPanel(props) {
<
BrowserRouter
>
<
Switch
>
<
Route
path
=
"
/reset/:token
"
component
=
{
ResetPassword
}
/
>
<
Route
path
=
"
/nreset/:token
"
>
<
ResetPassword
login
/>
<
/Route
>
<
Route
path
=
"
/reset/
"
component
=
{
ResetRequest
}
/
>
<
Route
path
=
"
/
"
>
<
SignIn
onLogin
=
{
props
.
onLogin
}
/
>
...
...
This diff is collapsed.
Click to expand it.
src/ResetPassword.js
+
10
−
5
View file @
1a205c51
...
...
@@ -5,11 +5,12 @@ import PasswordForm from "./PasswordForm";
import
Sender
from
"
./Sender
"
;
import
{
url
}
from
"
./util
"
;
function
ResetPassword
(
props
)
{
function
ResetPassword
()
{
const
[
password
,
setPassword
]
=
useState
(
""
);
const
[
login
,
setLogin
]
=
useState
(
""
);
const
[
validPass
,
setValidPass
]
=
useState
(
false
);
const
[
validToken
,
setValidToken
]
=
useState
(
"
loading
"
);
const
[
needsLogin
,
setNeedsLogin
]
=
useState
(
false
);
const
[
success
,
setSuccess
]
=
useState
(
false
);
const
{
token
}
=
useParams
();
...
...
@@ -17,7 +18,11 @@ function ResetPassword(props) {
if
(
validToken
===
"
loading
"
)
{
fetch
(
url
(
"
/api/reset/
"
+
token
)).
then
((
response
)
=>
{
setValidToken
(
response
.
ok
);
});
return
response
.
json
();
})
.
then
((
member
)
=>
{
setNeedsLogin
(
!
member
.
login
);
});
}
});
...
...
@@ -50,11 +55,11 @@ function ResetPassword(props) {
);
}
const
body
=
props
.
l
ogin
?
{
password
,
login
}
:
{
password
};
const
disabled
=
!
validPass
||
(
props
.
l
ogin
&&
!
login
);
const
body
=
needsL
ogin
?
{
password
,
login
}
:
{
password
};
const
disabled
=
!
validPass
||
(
needsL
ogin
&&
!
login
);
let
head
=
<
h2
>
Cambio
de
contraseña
<
/h2>
;
if
(
props
.
l
ogin
)
{
if
(
needsL
ogin
)
{
head
=
(
<
div
>
<
h2
>
Configura
tu
nombre
de
acceso
y
contraseña
<
/h2
>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment