Non-zero rsync exit value always leads to backup interruption

See Debian bug "#677971":http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677971.

(from redmine: created on 2012-06-19, closed on 2012-06-21)

rhatto wrote:

See Debian bug "#677971":http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677971.

Commit "05f59608":https://git.sarava.org/?p=backupninja.git;a=commit;h=05f596080dc119cbb3b5c8fdf28be4f8e30d3118 addresses this issue by issuing fatal errors just on some of rsync exit statuses.

The rsync man page gives a bunch of possible exit values, so we might double check wich of those are really fatal for the rsync handler.

(from redmine: written on 2012-06-20)

Merged, thanks!

(from redmine: written on 2012-06-21)

Hi.

The warning message appears when rsync returns 0. This patch corrects that behaviour:

--- a/handlers/rsync.in
+++ b/handlers/rsync.in
@@ -1103,6 +1103,8 @@ function check_rsync_exit_status {
   fi
 
   case $1 in
+    0) return
+       ;;
     1|2|3|4|5|6|10|11|12|13|14|21)
        fatal "Rsync error $1 when trying to transfer $SECTION"
        ;;

(from redmine: written on 2012-06-29)

ddpaul wrote:

Hi.

The warning message appears when rsync returns 0. This patch corrects that behaviour: [...]

Applied in Git, thanks!

(from redmine: written on 2012-06-29)

Status changed to closed

mentioned in commit 05f59608