Skip to content
Snippets Groups Projects
Closed Symmetric encryption in dup handler is broken
  • View options
  • Symmetric encryption in dup handler is broken

  • View options
  • Closed Issue created by Grundik

    Sanity check in handlers/dup.in is incorrect:

    [ -n "$signpassword" -a -n "$signkey" -a -n "$encryptkey" -a "$signkey" != "$encryptkey" ] || fatal "The signpassword option must be set because signkey is different from encryptkey."

    It means "if sign password is set and sign key is set and encrypt key is set and sign key is not equals to encrypt key, then everything is ok, otherwise its an error". So, if sign key is not set (i.e. symmetric encryption are requested), this check would fail.

    I think, more correct check should be like this:

    if [ -z "$signpassword" -a -n "$signkey" -a -n "$encryptkey" -a "$signkey" != "$encryptkey" ] ; then
      fatal "The signpassword option must be set because signkey is different from encryptkey."
    fi

    "If sign password is not set and sign key is set and encrypt key is set and sign key not equals to encrypt key, its an error", as stated in error description.

    This issue could be related to #2603 (closed).

    Linked items ... 0

  • Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    Loading Loading Loading Loading Loading Loading Loading Loading Loading Loading