Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
backupninja
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Liberate
backupninja
Commits
114d1ea7
Commit
114d1ea7
authored
4 years ago
by
Jérôme Charaoui
Browse files
Options
Downloads
Patches
Plain Diff
unbreak-AC_PATH_PROG-bash.patch was integrated upstream
parent
6a12c7aa
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/series
+0
-1
0 additions, 1 deletion
debian/patches/series
debian/patches/unbreak-AC_PATH_PROG-bash.patch
+0
-25
0 additions, 25 deletions
debian/patches/unbreak-AC_PATH_PROG-bash.patch
with
0 additions
and
26 deletions
debian/patches/series
deleted
100644 → 0
+
0
−
1
View file @
6a12c7aa
unbreak-AC_PATH_PROG-bash.patch
This diff is collapsed.
Click to expand it.
debian/patches/unbreak-AC_PATH_PROG-bash.patch
deleted
100644 → 0
+
0
−
25
View file @
6a12c7aa
From: Andreas Henriksson <andreas@fatal.se>
Subject: unbreak AC_PATH_PROG bash
Being able to set the variable name in the environment before
running configure is a documented feature of AC_PATH_PROG.
Explicitly unsetting the variable ofcourse breaks that feature.
If someone thinks BASH is not a good variable name because it
might be used for something else already, then either sanitize
your build environment or use a different variable name!
The hypothetical case in the comment isn't relevant in our build
environment, so unbreak things here by commenting out the unset....
--- backupninja-1.1.0.orig/configure.ac
+++ backupninja-1.1.0/configure.ac
@@ -11,7 +11,7 @@
AM_INIT_AUTOMAKE([foreign])
# BASH may already be set in the shell, if the admin then changes the
# the /bin/sh symlink to a non-bash shell, all hell will break lose.
-unset BASH
+#unset BASH
AC_PATH_PROGS(BASH, bash, "no", [$PATH:/bin:/usr/bin:/usr/sbin])
if test x$BASH = "xno"; then
AC_MSG_ERROR([bash is required])
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment