Skip to content
Snippets Groups Projects
Unverified Commit 4e3bde35 authored by Simone Basso's avatar Simone Basso Committed by GitHub
Browse files

oonitemplates: remove code causing crash on x86/arm64 (#360)

The matter is better explained in the newly added code comment. I feel
okay removing the code, because that was a okay-lets-test-it piece of
code that was only useful for running such test.

A key takeaway from the investigation of this issue is that we really
want to simplify and streamline the way in which netx interacts with
the rest of the world, to avoid using channels where we can more easily
have (1) code that directly logs, if logging is the intent, and (2)
code that directly saves data, if that is the intent.

I will open an issue to document these changes more in depth. Here as
a general reflection, I'd just like to reiterate that if we were using
less complex/general channel based patterns, we would be reducing the
odds that we see some unexpected behaviour like in this case.

Another aspect is that we should have QA running everytime we do
generate a new Android build - see https://github.com/ooni/probe-engine/issues/358.

Closes https://github.com/ooni/probe-engine/issues/355
parent f4dcad95
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment