fiX: tests need different names, warnings

lib/nickserver/reel_server.rb

@@ -43,7 +43,7 @@ module Nickserver
           handler.respond_to params(request), request.headers
         end
       end
-    rescue StandardError => e
+    rescue StandardError
       request.respond 500, "{}"
     end
 

test/functional/sample_test.rb

@@ -18,19 +18,19 @@ class SampleTest < FunctionalTest
   #   assert_lookup_status 400, 'invalid'
   # end
 
-  def test_nicknym
+  def test_nicknym_success
     assert_lookup_status 200, 'test@mail.bitmask.net'
   end
 
   # Regression Tests
 
   # #3 handle missing A records
-  def test_nicknym
+  def test_nicknym_handles_missing_a_record
     assert_lookup_status 404, 'postmaster@cs.ucl.ac.uk'
   end
 
   # platform/#8674 handle nonexisting domains
-  def test_nicknym
+  def test_nicknym_handles_missing_domain
     assert_lookup_status 404, 'postmaster@now-dont-you-dare-register-this-domain.coop'
   end
 

test/support/http_stub_helper.rb

@@ -27,8 +27,7 @@ module HttpStubHelper
 
   def stub_couch_response(uid, response = {})
     query = "\?key=#{"%22#{uid}%22"}&reduce=false"
-    stub_http_get /#{Regexp.escape(config.couch_url)}.*#{query}/,
-      response
+    stub_http_get(/#{Regexp.escape(config.couch_url)}.*#{query}/, response)
   end
 
   private