Update urls in provider config for bitmask provider

Issue: #269 (closed)

changed milestone to %2025.02 LEAP VPN Release

assigned to @peanut2

There is still an open TODO: We need an URL for the terms of service for the bitmask provider. I couldn't find it online. The old link (https://demo.bitmask.net/tos) does not work anymore.

Yet another update:

• in the provider config, ther is a field caURL
• in the repo, the ca cert is hardcoded:

pea@peabox:bitmask-vpn git ls-files | grep ca.crt                      
branding/scripts/check-ca-crt
providers/bitmask/bitmask-ca.crt
providers/calyx/calyx-ca.crt
providers/demolib/demolib-ca.crt
providers/floatdemo/floatdemo-ca.crt
providers/riseup/riseup-ca.crt
providers/riseupbeta/riseupbeta-ca.crt

• there is a target vendor_check which calls the python script branding/scripts/check-ca-crt
  • it checks if the online version (url in the config) and the local file (providers/bitmask/bitmask-ca.crt) matches

pea@peabox:bitmask-vpn make vendor_check
[+] Checking your provider config...
[+] CA file ok: /home/pea/projects/leap/bitmask-vpn/providers/bitmask/bitmask-ca.crt
... checking cert from https://api.ft1.bitmask.net/ca.crt
[!] ERROR: remote and local CA certs do not match
make: *** [Makefile:356: vendor_check] Error 1

This could be simplified:

• dont save ca.crt in the repo
• instead, fetch it from the url
• we don't use vendor_check right now - we should add it to the allinone target or remove it

This is normal for the desktop, right? As we don't have a /json endpoint for bitmask

2024-11-05T11:46:07+01:00 WRN Could not fetch geolocation error="Post \"https://menshen.ft1.bitmask.net/json\": dial tcp: lookup menshen.ft1.bitmask.net: no such host"                                                                        2024-11-05T11:46:07+01:00 TRC Setting GUI status status=starting                                                                                                                                                                               
2024-11-05T11:46:07+01:00 WRN Could not fetch geolocation error="Post \"https://menshen.ft1.bitmask.net/json\": dial tcp: lookup menshen.ft1.bitmask.net: no such host"                                                                        
2024-11-05T11:46:07+01:00 INF Got best gateway [{gw2.ft1.bitmask.net 37.218.245.94 North Brabant Netherlands NL [53 80 1194] [tcp udp] map[] openvpn} {gwft1.ft1.bitmask.net 37

added 2 commits

• 467c02e7 - Update urls in provider config for bitmask provider
• ccc3595c - [Makefile] Call vendor_check in allinone target

Compare with previous version

added 30m of time spent at 2024-11-04

requested review from @jkito

marked this merge request as draft

added 1 commit

• b62f9ca1 - Update urls in provider config for bitmask provider

Compare with previous version

resolved all threads

added 15m of time spent at 2024-11-05

marked this merge request as ready

changed the description

mentioned in issue #921 (closed)

approved this merge request

merged