enable setting introducer url using env variable

requested review from @peanut2

Can you please add LEAP_INTRODUCER_URL env to docs/debug.rst?

Hey,

Have you tested this? I had some issues and pushed some fixes:

When running with
LEAP_INTRODUCER_URL="obfsvpnintro://localhost:4430/?cert=MpRqHUJtZuL1ZUB3agXPGJJ0aZTIc20N5haBkAllf2CaTnaWOAtJGfUCgv0XCOJzt1qpfQ&fqdn=localhost&kcp=0"
I got:

2024-10-16T08:41:34+02:00 DBG failed to create http client from introducer error="expected a FQDN, got: localhost"

This was fixed in bitmask-core, so I updated the dependency.

Then I needed to fix the recent API changes in DoGeolocationLookup. It now only returns an error. Before also a string was returned.

Then, when I tried, I got:

2024-10-16T08:54:55+02:00 WRN Could not update lastUsed timestamp for introducer error="introducer not found"

So we need to add the introducer to the database first. How do we want to handle this? We could run storage.AddIntroducer(url), but this part is currently only used/encapsulated in bitmaks-core. Also we need to remove it from the database after the run. So it's not super simple. What do you think? Let me think about this again

No did not test it yet, thanks for doing that, feel free to add more commits to fix it up!

So we need to add the introducer to the database first. How do we want to handle this? We could run storage.AddIntroducer(url), but this part is currently only used/encapsulated in bitmaks-core. Also we need to remove it from the database after the run. So it's not super simple. What do you think? Let me think about this again

i think this belongs in bitmask-core itself, when it tries to update the lastUsed timestamp if it doesn't find a introducer it can simply add it to the storage, iirc this was the behavior before in bitmask-core when using the earlier version of the storage mechanism

Hm, I like to be explicit and keep it the way it currently is: add, use it and remove introducer (from storage layer). What do you say @cyberta

I don't have a strong opinion on that. Either works, I have a slight preference for keeping add and update as different actions. Explicitly adding an introducer makes it maybe easier to follow the code? There are some other code changes in the pipeline regarding the storage layer to avoid implicit initialization of it (bitmask-core#24). Having distinct actions add, update and remove seems to fit in that context.

I now have a working version that I'm happy with. @jkito can you review please? I use this go.work:

go 1.22.2

use (
    .
    ../bitmask-core
)

There, I'm on origin/fix-29 which fixes some introducerURL things. To test, I use

export LEAP_INTRODUCER_URL="obfsvpnintro://localhost:4430/?cert=HtqKzIacN3%2Ba6AAS%2BXlnw%2FlEgHRLIm%2BmEFtIgFQ26vxWa4aFy07XhWIRjK6kZ1YpxejkRA&fqdn=localhost&kcp=0&auth=123"

(Don't forget to url encode). If you have problems with the test setup, just ask.

btw: I only tested it with V5, so it probably won't work with v3. Need to check it.

added 5 commits

7e176df8 - 1 commit from branch main
3d692de0 - chore: replace ioutil with io module
a76e1ddb - enable setting introducer url using env variable
4a2204df - Update to latest bitmask-core (commit 0812b9aadf98)
a823f622 - Update calls to DoGeolocationLookup after API change

Compare with previous version

added 2 commits

9a0b0824 - Improve error handling when checking downloaded pem cert
776d7e95 - DEV: Add introducer to storage if not yet happened

Compare with previous version

assigned to @peanut2

There are more things to fix. Now we have a version that works (most of the time) with v5. But there is still a database issue. And a corner case bug:

2024-10-16T10:27:55+02:00 TRC Checking for a valid OpenVPN client credentials (key and certificate) path=/tmp/leap-566310687/openvpn.pem               
2024-10-16T10:27:55+02:00 WRN Could not decode pem data data="404 page not found\n"     

T 127.0.0.1:41124 -> 127.0.0.1:8443 [AP] #774                                                                          
GET /api/5/openvpn/cert HTTP/1.1.                                                                                      
Host: localhost:8443.                                                                                                  
User-Agent: Go-http-client/1.1.                                                                                        
Accept: application/json.                                                                                              
Accept-Encoding: gzip.                                     
.                                                          
                                                           
                                                           
T 127.0.0.1:8443 -> 127.0.0.1:41124 [AP] #776              
HTTP/1.1 200 OK.                                           
Cache-Control: no-cache.                                   
Content-Type: text/plain; charset=UTF-8.
Date: Wed, 16 Oct 2024 08:27:55 GMT.
Content-Length: 19.                                        
.                                                          
404 page not found